From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6318A219EB; Tue, 20 May 2025 05:55:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747720543; cv=none; b=jF+PndSNRM2S9W3ZhNqJ0L7t7zo48trFzrV6sRdvZ9tB4c3Dhz4E4nx2OY+QAZUbDOKdBAAnvviv31cGN8fb9p1Srp3qEGzBsAkYAJBfu/Apix8tP00EygGSAZkttbQsax8M5KdcWfSEKy58ctZbMX0kbJdzJAGulkIplBo7l/Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747720543; c=relaxed/simple; bh=3muCC4E7LtauJGp0GuU5sADeKiTqSk6vogl0HiydJiI=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=AW1xQfcrs+vadqTygJP6BpgHMwBLSurAcTmCF4Z3M/zw4RJ36M2fkYZyxmzWJnhz/f7bZvxFNECCv24z6TN1vkCPb2t830ivPPLdbITYmvKIva+A0N1DvAJmrhNbop2eaSWDPSOiAm9DLCBxPAWxthD/7A2FFAD2U6TiXwAn/bw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=OQ6WMedy; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OQ6WMedy" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0CFB8C4CEE9; Tue, 20 May 2025 05:55:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747720542; bh=3muCC4E7LtauJGp0GuU5sADeKiTqSk6vogl0HiydJiI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=OQ6WMedyGLB1x2K6UyJgoOyw/S19yUboB1np/LU7UXVswU6/ohA2x/WWe/nw8obPz z1zTs8RbKk9dbk4SALMWVPEnVw5e9FM2GLNcWIub3Qu9sXsijhGJsam99hYz/0v/Gr PADsRmeLXr/0RCncGeeuJqlYpg3UpDLgLlfZpPxwtNAa+p9HNIY/T2ydGL7v0cBDp1 /ftvGwrMaviKweG1/gZ+wy9bt4RfQjEbeA8yLh8Ca5O91rmabQgkGyX7d5VFdDvQyX nL4AH5SjR7r3+qRdvM0CVJ1uJ6ukcEzNJA3Sz4O/ez4p/5BCu9P21Y2RyDSY6ZG+OE PCobTfidlZW5w== Date: Tue, 20 May 2025 07:55:38 +0200 From: Mauro Carvalho Chehab To: Randy Dunlap Cc: Akira Yokosawa , Stephen Rothwell , corbet@lwn.net, linux-kernel@vger.kernel.org, linux-next@vger.kernel.org, Dan Williams , linux-doc@vger.kernel.org Subject: Re: linux-next: build failure after merge all the trees Message-ID: <20250520075538.57a12325@foz.lan> In-Reply-To: <20250520071802.5700d42f@foz.lan> References: <20250508184839.656af8f6@canb.auug.org.au> <3b35840a-7b87-44fc-8580-219ac78ad112@gmail.com> <20250508222531.0e7fab9c@canb.auug.org.au> <20250508143911.5d7a77d4@foz.lan> <879b49f5-7350-48e8-a84e-2c580a5b0ca8@gmail.com> <0a6cbe7b-814b-407c-ac1c-96ab7b787d88@infradead.org> <20250520071802.5700d42f@foz.lan> X-Mailer: Claws Mail 4.3.1 (GTK 3.24.49; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Em Tue, 20 May 2025 07:18:02 +0200 Mauro Carvalho Chehab escreveu: > Em Mon, 19 May 2025 12:33:03 -0700 > Randy Dunlap escreveu: > > > On 5/14/25 7:33 PM, Akira Yokosawa wrote: > > > [+CC linux-doc] > > > > > > Hi, > > > > > > On Thu, 8 May 2025 14:39:11 +0200, Mauro Carvalho Chehab wrote: > > >> Em Thu, 8 May 2025 22:25:31 +1000 > > >> Stephen Rothwell escreveu: > > > [...] > > > > > >>> > > >>> So, I used "KERNELDOC=$(pwd)/scripts/kernel-doc.pl" and tried again. > > >>> > > >>> I got these (new) messages: > > >>> > > >>> Error: Cannot open file drivers/virt/coco/tsm-mr.c > > >>> Error: Cannot open file drivers/virt/coco/tsm-mr.c > > >>> WARNING: kernel-doc 'scripts/kernel-doc.pl -rst -enable-lineno -export drivers/virt/coco/tsm-mr.c' failed with return code 2 > > >>> > > >>> (and a few other innocuous ones) > > >>> > > >>> So your guess is good. > > >>> > > >>> It would be nice to have the Python kernel-doc fixed as well as the > > >>> devsec-tsm tree. > > >> > > >> With regards to kernel-doc, failing to build if a file is missing > > >> is the right thing to do. > > > > > > Mauro, I don't agree here. > > > > > > With the perl version of kernel-doc, a typo in a file path doesn't cause > > > a fatal error of docs build. > > > > > > kernel-doc as python class libs ends up in a fatal error. > > > > > > Here is a log of such a fatal error (on top of current docs-next with > > > intentional typo made in a pathname in one of .. kernel-doc:: > > > > > > ----------------------------------------------------------------- > > > Sphinx parallel build error! > > > > > > Versions > > > ======== > > > > > > * Platform: linux; (Linux-6.8.0-59-generic-x86_64-with-glibc2.39) > > > * Python version: 3.12.3 (CPython) > > > * Sphinx version: 8.2.3 > > > * Docutils version: 0.21.2 > > > * Jinja2 version: 3.1.6 > > > * Pygments version: 2.19.1 > > > > > > Last Messages > > > ============= > > > > > > userspace-api/gpio/gpio-get-chipinfo-ioctl .. userspace-api/media/dvb/dmx-fclose > > > > > > > > > reading sources... [ 90%] > > > userspace-api/media/dvb/dmx-fopen .. userspace-api/media/mediactl/media-controller-model > > > > > > > > > reading sources... [ 92%] > > > userspace-api/media/mediactl/media-func-close .. userspace-api/media/v4l/diff-v4l > > > > > > Loaded Extensions > > > ================= > > > > > > * sphinx.ext.mathjax (8.2.3) > > > * alabaster (1.0.0) > > > * sphinxcontrib.applehelp (2.0.0) > > > * sphinxcontrib.devhelp (2.0.0) > > > * sphinxcontrib.htmlhelp (2.1.0) > > > * sphinxcontrib.serializinghtml (2.0.0) > > > * sphinxcontrib.qthelp (2.0.0) > > > * kerneldoc (1.0) > > > * rstFlatTable (1.0) > > > * kernel_include (1.0) > > > * kfigure (1.0.0) > > > * sphinx.ext.ifconfig (8.2.3) > > > * automarkup (unknown version) > > > * maintainers_include (1.0) > > > * sphinx.ext.autosectionlabel (8.2.3) > > > * kernel_abi (1.0) > > > * kernel_feat (1.0) > > > * translations (unknown version) > > > * sphinx.ext.imgmath (8.2.3) > > > > > > Traceback > > > ========= > > > > > > File "/<...>/sphinx-8.2.3/lib/python3.12/site-packages/sphinx/util/parallel.py", line 137, in _join_one > > > raise SphinxParallelError(*result) > > > sphinx.errors.SphinxParallelError: KeyError: '/<...>/lib/bitmap-bad.c' > > > > > > > > > The full traceback has been saved in: > > > /tmp/sphinx-err-8jzxndsr.log > > > > > > To report this error to the developers, please open an issue at . Thanks! > > > Please also report this if it was a user error, so that a better error message can be provided next time. > > > make[3]: *** [/<...>/Documentation/Makefile:123: htmldocs] Error 2 > > > make[2]: *** [/<...>/Makefile:1806: htmldocs] Error 2 > > > make[1]: *** [/<...>/Makefile:248: __sub-make] Error 2 > > > make[1]: Leaving directory '/<...>/my-output' > > > make: *** [Makefile:248: __sub-make] Error 2 > > > > > > ----------------------------------------------------------------- > > > > > > This would surprise innocent devs who are kindly willing to test docs build. > > > > > > I think you need to tame its behavior and make it emit a proper warning and > > > continue building docs in case of such predictable user errors. > > > > Totally agree. > > I also agree. > > The main difference between calling kernel-doc via a shell script or > via a Python class is that now errors flow via Sphinx logger class, > so they are subject to Sphinx filtering rules. > > I double-checked: the logs are produced, and you can see them with "V=1", > but Sphinx is hiding them, perhaps because of some options passed through > sphinx-build call, or because they require them to have certain types. > > A quick workaround would be to not use Sphinx logger anymore (see > enclosed). It has a side effect, though: we lose control of setting > it via V= variable, which is not good. Heh, V=1 is not actually affected by not using Sphinx logger inside the class. So, I can't see a side effect of letting the kernel-doc use directly Python logger instead of the Sphinx variant. So, I submitted the fix at: https://lore.kernel.org/linux-doc/cover.1747719873.git.mchehab+huawei@kernel.org/T/#t As we may want to revisit it later in the future, in case Sphinx makes something more fancy there, I added a comment at the patch. Thanks, Mauro