mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Huan Tang <tanghuan@vivo.com>
To: alok.a.tiwari@oracle.com
Cc: James.Bottomley@HansenPartnership.com, alim.akhtar@samsung.com,
	angelogioacchino.delregno@collabora.com, avri.altman@wdc.com,
	bvanassche@acm.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
	linux-scsi@vger.kernel.org, luhongfei@vivo.com,
	manivannan.sadhasivam@linaro.org, martin.petersen@oracle.com,
	matthias.bgg@gmail.com, opensource.kernel@vivo.com,
	peter.wang@mediatek.com, quic_nguyenb@quicinc.com,
	tanghuan@vivo.com, wenxing.cheng@vivo.com
Subject: Re: Re: [PATCH v4] ufs: core: Add HID support
Date: Tue, 20 May 2025 17:48:01 +0800	[thread overview]
Message-ID: <20250520094801.411-1-tanghuan@vivo.com> (raw)
In-Reply-To: <8faf7a11-b312-4062-89a5-8aff192ee1da@oracle.com>

Hi alok sir,

Thank you for your comments and guidance!
The v5 patch:
https://lore.kernel.org/all/20250520094054.313-1-tanghuan@vivo.com/

> typo indicateds -> indicates
>
> Idle (analysis required)
>
> remove extra ' ' after umode_t
>
> _IS_ is extra in an enum label, or sound redundant.
> I think DEFRAG_NOT_REQUIRED sounds cleaner, especially since it's used 
> with return "defrag_not_required".
OK! It has been modified in the v5 patch.

Thanks
Huan



      reply	other threads:[~2025-05-20  9:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-20  6:35 Huan Tang
2025-05-20  7:45 ` ALOK TIWARI
2025-05-20  9:48   ` Huan Tang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250520094801.411-1-tanghuan@vivo.com \
    --to=tanghuan@vivo.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=alim.akhtar@samsung.com \
    --cc=alok.a.tiwari@oracle.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=avri.altman@wdc.com \
    --cc=bvanassche@acm.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=luhongfei@vivo.com \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=martin.petersen@oracle.com \
    --cc=matthias.bgg@gmail.com \
    --cc=opensource.kernel@vivo.com \
    --cc=peter.wang@mediatek.com \
    --cc=quic_nguyenb@quicinc.com \
    --cc=wenxing.cheng@vivo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®