mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christian Hesse <mail@eworm.de>
To: "Xu, Lizhi" <Lizhi.Xu@windriver.com>
Cc: "hch@infradead.org" <hch@infradead.org>,
	"axboe@kernel.dk" <axboe@kernel.dk>,
	"christian@heusel.eu" <christian@heusel.eu>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"ming.lei@redhat.com" <ming.lei@redhat.com>,
	"syzbot+6af973a3b8dfd2faefdc@syzkaller.appspotmail.com"
	<syzbot+6af973a3b8dfd2faefdc@syzkaller.appspotmail.com>,
	"syzkaller-bugs@googlegroups.com"
	<syzkaller-bugs@googlegroups.com>
Subject: Re: [PATCH V5] loop: Add sanity check for read/write_iter
Date: Tue, 20 May 2025 14:46:22 +0200	[thread overview]
Message-ID: <20250520144622.3fd9592a@leda.eworm.net> (raw)
In-Reply-To: <BL1PR11MB5979EFA72DA54AB231D408CF869FA@BL1PR11MB5979.namprd11.prod.outlook.com>

[-- Attachment #1: Type: text/plain, Size: 631 bytes --]

"Xu, Lizhi" <Lizhi.Xu@windriver.com> on Tue, 2025/05/20 12:27:
> If it is a regular file, generic_ro_fops is used. In this case,
> isofs supports read_iter. When a regular file has a writable attribute,

Just tested with an iso file where writable flag from loopback file inside
was explicitly removed. No change.

> the problem will recur because isofs does not support write_iter.

We have two indications here that setup should happen in read-only mode:

* The underlaying filesystem is read-only
* `losetup` is called with switch `--read-only`

I would expect both to make this happy.
-- 
Best regards,
Chris

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2025-05-20 12:46 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-24 14:08 [syzbot] [block?] BUG: unable to handle kernel NULL pointer dereference in lo_rw_aio syzbot
2025-04-25  1:19 ` [syzbot] " syzbot
2025-04-25  1:55 ` syzbot
2025-04-25  3:40 ` [PATCH] loop: Add sanity check for read/write_iter Lizhi Xu
2025-04-25  4:06   ` Zhu Yanjun
2025-04-25  4:19     ` Lizhi Xu
2025-04-25  4:20   ` Ming Lei
2025-04-25  4:33     ` Lizhi Xu
2025-04-25  5:38     ` [PATCH V2] " Lizhi Xu
2025-04-25 13:28       ` Christoph Hellwig
2025-04-26  1:50         ` Lizhi Xu
2025-04-28 12:46           ` Christoph Hellwig
2025-04-28 13:48             ` Lizhi Xu
2025-04-28 13:49               ` Christoph Hellwig
2025-04-26  2:10         ` [PATCH V3] " Lizhi Xu
2025-04-28 12:49           ` Christoph Hellwig
2025-04-28 13:42             ` Lizhi Xu
2025-04-28 13:48               ` Christoph Hellwig
2025-04-28 14:15                 ` [PATCH V4] " Lizhi Xu
2025-04-28 14:26                   ` Christoph Hellwig
2025-04-28 14:36                     ` [PATCH V5] " Lizhi Xu
2025-05-05 13:18                       ` Jens Axboe
2025-05-19 15:56                       ` Christian Hesse
2025-05-20  3:00                         ` Lizhi Xu
2025-05-20  5:39                           ` Christian Hesse
2025-05-20  6:29                             ` 回复: " Xu, Lizhi
2025-05-20  6:31                               ` Christian Hesse
2025-05-20  6:49                                 ` Xu, Lizhi
2025-05-20  6:46                               ` 回复: " hch
2025-05-20  6:59                                 ` 回复: " Xu, Lizhi
2025-05-20 11:28                                   ` hch
2025-05-20 11:39                                     ` 回复: " Xu, Lizhi
2025-05-20 11:41                                       ` hch
2025-05-20 11:44                                         ` 回复: " Xu, Lizhi
2025-05-20 11:52                                           ` Xu, Lizhi
2025-05-20 12:27                                 ` Xu, Lizhi
2025-05-20 12:46                                   ` Christian Hesse [this message]
2025-05-20 12:49                                     ` hch
2025-05-20 13:12                                       ` Xu, Lizhi
2025-05-20 16:53                                       ` christian
2025-05-20 12:46                                   ` hch
2025-04-25  4:54 ` [syzbot] Re: [syzbot] [block?] BUG: unable to handle kernel NULL pointer dereference in lo_rw_aio syzbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250520144622.3fd9592a@leda.eworm.net \
    --to=mail@eworm.de \
    --cc=Lizhi.Xu@windriver.com \
    --cc=axboe@kernel.dk \
    --cc=christian@heusel.eu \
    --cc=hch@infradead.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    --cc=syzbot+6af973a3b8dfd2faefdc@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®