From: Remo Senekowitsch <remo@buenzli.dev>
To: "Rob Herring" <robh@kernel.org>,
"Saravana Kannan" <saravanak@google.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Dirk Behme" <dirk.behme@de.bosch.com>,
"Remo Senekowitsch" <remo@buenzli.dev>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
rust-for-linux@vger.kernel.org
Subject: [PATCH v5 2/9] rust: device: Enable accessing the FwNode of a Device
Date: Tue, 20 May 2025 22:00:17 +0200 [thread overview]
Message-ID: <20250520200024.268655-3-remo@buenzli.dev> (raw)
In-Reply-To: <20250520200024.268655-1-remo@buenzli.dev>
Subsequent patches will add methods for reading properties to FwNode.
The first step to accessing these methods will be to access the "root"
FwNode of a Device.
Add the method `fwnode` to `Device`.
Signed-off-by: Remo Senekowitsch <remo@buenzli.dev>
---
rust/kernel/device.rs | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/rust/kernel/device.rs b/rust/kernel/device.rs
index d8619d4485fb4..b4b7056eb80f8 100644
--- a/rust/kernel/device.rs
+++ b/rust/kernel/device.rs
@@ -186,6 +186,21 @@ unsafe fn printk(&self, klevel: &[u8], msg: fmt::Arguments<'_>) {
};
}
+ /// Obtain the [`FwNode`](property::FwNode) corresponding to the device.
+ pub fn fwnode(&self) -> Option<&property::FwNode> {
+ // SAFETY: `self` is valid.
+ let fwnode_handle = unsafe { bindings::__dev_fwnode(self.as_raw()) };
+ if fwnode_handle.is_null() {
+ return None;
+ }
+ // SAFETY: `fwnode_handle` is valid. Its lifetime is tied to `&self`. We
+ // return a reference instead of an `ARef<FwNode>` because `dev_fwnode()`
+ // doesn't increment the refcount. It is safe to cast from a
+ // `struct fwnode_handle*` to a `*const FwNode` because `FwNode` is
+ // defined as a `#[repr(transparent)]` wrapper around `fwnode_handle`.
+ Some(unsafe { &*fwnode_handle.cast() })
+ }
+
/// Checks if property is present or not.
pub fn property_present(&self, name: &CStr) -> bool {
// SAFETY: By the invariant of `CStr`, `name` is null-terminated.
--
2.49.0
next prev parent reply other threads:[~2025-05-20 20:00 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-20 20:00 [PATCH v5 0/9] More Rust bindings for device property reads Remo Senekowitsch
2025-05-20 20:00 ` [PATCH v5 1/9] rust: device: Create FwNode abstraction for accessing device properties Remo Senekowitsch
2025-05-20 20:00 ` Remo Senekowitsch [this message]
2025-05-21 11:59 ` [PATCH v5 2/9] rust: device: Enable accessing the FwNode of a Device Greg Kroah-Hartman
2025-05-21 12:45 ` Remo Senekowitsch
2025-05-20 20:00 ` [PATCH v5 3/9] rust: device: Add property_present() to FwNode Remo Senekowitsch
2025-05-20 20:00 ` [PATCH v5 4/9] rust: device: Enable printing fwnode name and path Remo Senekowitsch
2025-05-21 12:02 ` Greg Kroah-Hartman
2025-05-21 13:03 ` Remo Senekowitsch
2025-05-21 16:58 ` Greg Kroah-Hartman
2025-05-21 18:36 ` Remo Senekowitsch
2025-05-21 19:13 ` Danilo Krummrich
2025-05-22 4:49 ` Greg Kroah-Hartman
2025-05-22 5:47 ` Danilo Krummrich
2025-05-21 12:38 ` Miguel Ojeda
2025-05-20 20:00 ` [PATCH v5 5/9] rust: device: Introduce PropertyGuard Remo Senekowitsch
2025-05-20 20:00 ` [PATCH v5 6/9] rust: device: Implement accessors for firmware properties Remo Senekowitsch
2025-05-21 21:34 ` kernel test robot
2025-05-22 20:23 ` Benno Lossin
2025-05-20 20:00 ` [PATCH v5 7/9] rust: device: Add child accessor and iterator Remo Senekowitsch
2025-05-20 20:00 ` [PATCH v5 8/9] rust: device: Add property_get_reference_args Remo Senekowitsch
2025-05-20 20:00 ` [PATCH v5 9/9] samples: rust: platform: Add property read examples Remo Senekowitsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250520200024.268655-3-remo@buenzli.dev \
--to=remo@buenzli.dev \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dirk.behme@de.bosch.com \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=saravanak@google.com \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®