mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Johan Adolfsson <johan.adolfsson@axis.com>
To: Lee Jones <lee@kernel.org>, Pavel Machek <pavel@kernel.org>,
	"Jacek Anaszewski" <jacek.anaszewski@gmail.com>
Cc: <linux-leds@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	"Johan Adolfsson" <johan.adolfsson@axis.com>, <kernel@axis.com>
Subject: [PATCH RFC v2 2/2] dt-bindings: leds: lp50xx: Document child reg, fix example
Date: Thu, 22 May 2025 16:14:49 +0200	[thread overview]
Message-ID: <20250522-led-fix-v2-2-652046323ec3@axis.com> (raw)
In-Reply-To: <20250522-led-fix-v2-0-652046323ec3@axis.com>

The led child reg node is the index within the bank, document that
and update the example accordingly.

Signed-off-by: Johan Adolfsson <johan.adolfsson@axis.com>
---
 Documentation/devicetree/bindings/leds/leds-lp50xx.yaml | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml b/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
index 402c25424525..8ce327d00c2d 100644
--- a/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
+++ b/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
@@ -82,6 +82,11 @@ patternProperties:
         properties:
           reg:
             maxItems: 1
+            description:
+              This property denotes the index within the LED bank, 0, 1 or 2.
+              The value is actually optional for backward compatibility reasons
+              but is highly recommended to handle reversed devicetree
+              processing properly.
 
         required:
           - reg
@@ -139,17 +144,17 @@ examples:
                 function = LED_FUNCTION_STANDBY;
 
                 led@3 {
-                    reg = <0x3>;
+                    reg = <0x0>;
                     color = <LED_COLOR_ID_RED>;
                 };
 
                 led@4 {
-                    reg = <0x4>;
+                    reg = <0x1>;
                     color = <LED_COLOR_ID_GREEN>;
                 };
 
                 led@5 {
-                    reg = <0x5>;
+                    reg = <0x2>;
                     color = <LED_COLOR_ID_BLUE>;
                 };
             };

-- 
2.30.2


  parent reply	other threads:[~2025-05-22 14:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-22 14:14 [PATCH RFC v2 0/2] leds-lp50xx: Support reg to set multi_index Johan Adolfsson
2025-05-22 14:14 ` [PATCH RFC v2 1/2] leds: leds-lp50xx: Handle reg to get correct multi_index Johan Adolfsson
2025-05-22 14:14 ` Johan Adolfsson [this message]
2025-05-22 17:40   ` [PATCH RFC v2 2/2] dt-bindings: leds: lp50xx: Document child reg, fix example Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250522-led-fix-v2-2-652046323ec3@axis.com \
    --to=johan.adolfsson@axis.com \
    --cc=jacek.anaszewski@gmail.com \
    --cc=kernel@axis.com \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=pavel@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®