From: Alex Williamson <alex.williamson@redhat.com>
To: "Li,Rongqing" <lirongqing@baidu.com>
Cc: "kwankhede@nvidia.com" <kwankhede@nvidia.com>,
"yan.y.zhao@intel.com" <yan.y.zhao@intel.com>,
"cjia@nvidia.com" <cjia@nvidia.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [????] Re: [PATCH] vfio/type1: fixed rollback in vfio_dma_bitmap_alloc_all()
Date: Thu, 22 May 2025 11:52:31 -0600 [thread overview]
Message-ID: <20250522115231.729dad0c.alex.williamson@redhat.com> (raw)
In-Reply-To: <64e1bbd6b7e94aa0b5bc4556d5d335a6@baidu.com>
On Thu, 22 May 2025 01:53:48 +0000
"Li,Rongqing" <lirongqing@baidu.com> wrote:
> > vfio/type1: Fix error unwind in migration dirty bitmap allocation
> >
> > When setting up dirty page tracking at the vfio IOMMU backend for
> > device migration, if an error is encountered allocating a tracking
> > bitmap, the unwind loop fails to free previously allocated tracking
> > bitmaps. This occurs because the wrong loop index is used to
> > generate the tracking object. This results in unintended memory
> > usage for the life of the current DMA mappings where bitmaps were
> > successfully allocated.
> >
> > Use the correct loop index to derive the tracking object for
> > freeing during unwind.
> >
>
> Your changelog is extremely detailed and highly accurate.
>
> Please directly incorporate this patch with your changelog
Applied to vfio next branch for v6.16 with updated changelog. Thanks,
Alex
prev parent reply other threads:[~2025-05-22 17:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-21 3:46 lirongqing
2025-05-21 20:00 ` Alex Williamson
2025-05-22 1:53 ` 答复: [????] " Li,Rongqing
2025-05-22 17:52 ` Alex Williamson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250522115231.729dad0c.alex.williamson@redhat.com \
--to=alex.williamson@redhat.com \
--cc=cjia@nvidia.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lirongqing@baidu.com \
--cc=yan.y.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®