Re: [PATCH v3 4/5] media: dt-bindings: sony,imx214: Deprecate property clock-frequency

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi André,

Thank you for the patch.

On Wed, May 21, 2025 at 09:34:27PM +0200, André Apitzsch via B4 Relay wrote:
> From: André Apitzsch <git@apitzsch.eu>
> 
> Deprecate the clock-frequency property in favor of assigned-clock-rates.
> 
> While at it, re-order properties according to coding style and fix the
> link-frequency in the example.  See commit acc294519f17 ("media: i2c:
> imx214: Fix link frequency validation").
> 
> Signed-off-by: André Apitzsch <git@apitzsch.eu>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  .../devicetree/bindings/media/i2c/sony,imx214.yaml | 29 ++++++++++++----------
>  1 file changed, 16 insertions(+), 13 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx214.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx214.yaml
> index 0162eec8ca993a7614d29908f89fa9fe6d4b545d..aea99ebf8e9ed15f8066841228d9fdecc822b553 100644
> --- a/Documentation/devicetree/bindings/media/i2c/sony,imx214.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx214.yaml
> @@ -33,20 +33,21 @@ properties:
>  
>    clock-frequency:
>      description: Frequency of the xclk clock in Hz.
> +    deprecated: true
>  
>    enable-gpios:
>      description: GPIO descriptor for the enable pin.
>      maxItems: 1
>  
> -  vdddo-supply:
> -    description: Chip digital IO regulator (1.8V).
> -
>    vdda-supply:
>      description: Chip analog regulator (2.7V).
>  
>    vddd-supply:
>      description: Chip digital core regulator (1.12V).
>  
> +  vdddo-supply:
> +    description: Chip digital IO regulator (1.8V).
> +
>    flash-leds: true
>    lens-focus: true
>  
> @@ -84,11 +85,10 @@ required:
>    - compatible
>    - reg
>    - clocks
> -  - clock-frequency
>    - enable-gpios
> -  - vdddo-supply
>    - vdda-supply
>    - vddd-supply
> +  - vdddo-supply
>    - port
>  
>  unevaluatedProperties: false
> @@ -104,22 +104,25 @@ examples:
>          camera-sensor@1a {
>              compatible = "sony,imx214";
>              reg = <0x1a>;
> -            vdddo-supply = <&pm8994_lvs1>;
> -            vddd-supply = <&camera_vddd_1v12>;
> +
> +            clocks = <&camera_clk>;
> +            assigned-clocks = <&camera_clk>;
> +            assigned-clock-rates = <24000000>;
> +
> +            enable-gpios = <&msmgpio 25 GPIO_ACTIVE_HIGH>;
> +
>              vdda-supply = <&pm8994_l17>;
> +            vddd-supply = <&camera_vddd_1v12>;
> +            vdddo-supply = <&pm8994_lvs1>;
> +
>              lens-focus = <&ad5820>;
> -            enable-gpios = <&msmgpio 25 GPIO_ACTIVE_HIGH>;
> -            clocks = <&camera_clk>;
> -            clock-frequency = <24000000>;
>  
>              port {
>                  imx214_ep: endpoint {
>                      data-lanes = <1 2 3 4>;
> -                    link-frequencies = /bits/ 64 <480000000>;
> +                    link-frequencies = /bits/ 64 <600000000>;
>                      remote-endpoint = <&csiphy0_ep>;
>                  };
>              };
>          };
>      };
> -
> -...

-- 
Regards,

Laurent Pinchart