From: Sean Christopherson <seanjc@google.com>
To: Sean Christopherson <seanjc@google.com>,
Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Vipin Sharma <vipinsh@google.com>,
James Houghton <jthoughton@google.com>
Subject: [PATCH v4 0/4] KVM: x86: Dynamically allocate hashed page list
Date: Thu, 22 May 2025 17:11:34 -0700 [thread overview]
Message-ID: <20250523001138.3182794-1-seanjc@google.com> (raw)
Allocate the hashed list of shadow pages dynamically (separate from
struct kvm), and on-demand. The hashed list is 32KiB, i.e. absolutely
belongs in a separate allocation, and is worth skipping if KVM isn't
shadowing guest PTEs for the VM.
I double checked that padding kvm_arch with a 4KiB array trips the assert,
but padding with 2KiB does not. So knock on wood, I finally got the assert
right. Maybe.
v4:
- Use smp_store_release() and smp_load_acquire() instead of {READ,WRITE}_ONCE,
and update the comments accordingly. [Paolo, James]
- Move the kvm_tdx assert to tdx.c. [Paolo]
- Fix the assertion, again. [Vipin, in spirit if not in reality]
- Add a patch to move TDX hardware setup to tdx.c.
v3:
- https://lore.kernel.org/all/20250516215422.2550669-1-seanjc@google.com
- Add comments explaining the {READ,WRITE}_ONCE logic, and why it's safe
to set the list outside of mmu_lock. [Vipin]
- Make the assertions actually work. [Vipin]
- Refine the assertions so they (hopefully) won't fail on kernels with
a bunch of debug crud added.
v2:
- https://lore.kernel.org/all/20250401155714.838398-1-seanjc@google.com
- Actually defer allocation when using TDP MMU. [Vipin]
- Free allocation on MMU teardown. [Vipin]
v1: https://lore.kernel.org/all/20250315024010.2360884-1-seanjc@google.com
Sean Christopherson (4):
KVM: TDX: Move TDX hardware setup from main.c to tdx.c
KVM: x86/mmu: Dynamically allocate shadow MMU's hashed page list
KVM: x86: Use kvzalloc() to allocate VM struct
KVM: x86/mmu: Defer allocation of shadow MMU's hashed page list
arch/x86/include/asm/kvm_host.h | 6 +--
arch/x86/kvm/mmu/mmu.c | 75 ++++++++++++++++++++++++++++++---
arch/x86/kvm/svm/svm.c | 2 +
arch/x86/kvm/vmx/main.c | 36 +---------------
arch/x86/kvm/vmx/tdx.c | 47 +++++++++++++++------
arch/x86/kvm/vmx/tdx.h | 1 +
arch/x86/kvm/vmx/vmx.c | 2 +
arch/x86/kvm/vmx/x86_ops.h | 10 -----
arch/x86/kvm/x86.c | 5 ++-
arch/x86/kvm/x86.h | 22 ++++++++++
10 files changed, 139 insertions(+), 67 deletions(-)
base-commit: 3f7b307757ecffc1c18ede9ee3cf9ce8101f3cc9
--
2.49.0.1151.ga128411c76-goog
next reply other threads:[~2025-05-23 0:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-23 0:11 Sean Christopherson [this message]
2025-05-23 0:11 ` [PATCH v4 1/4] KVM: TDX: Move TDX hardware setup from main.c to tdx.c Sean Christopherson
2025-05-23 2:27 ` Xiaoyao Li
2025-05-23 6:40 ` Xiaoyao Li
2025-05-23 11:31 ` Huang, Kai
2025-05-23 0:11 ` [PATCH v4 2/4] KVM: x86/mmu: Dynamically allocate shadow MMU's hashed page list Sean Christopherson
2025-05-28 8:04 ` Xiaoyao Li
2025-05-28 12:54 ` Sean Christopherson
2025-06-24 19:48 ` Sean Christopherson
2025-05-23 0:11 ` [PATCH v4 3/4] KVM: x86: Use kvzalloc() to allocate VM struct Sean Christopherson
2025-05-28 8:35 ` Xiaoyao Li
2025-05-23 0:11 ` [PATCH v4 4/4] KVM: x86/mmu: Defer allocation of shadow MMU's hashed page list Sean Christopherson
2025-06-24 19:38 ` [PATCH v4 0/4] KVM: x86: Dynamically allocate " Sean Christopherson
2025-06-24 21:12 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250523001138.3182794-1-seanjc@google.com \
--to=seanjc@google.com \
--cc=jthoughton@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=vipinsh@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®