From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B48D4315A; Mon, 26 May 2025 13:15:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748265312; cv=none; b=V1Oa5iQFFl4OJZP47CbvyMFAAkKbinVtb1cwaCpTq9ISK6QmU8AM/RJuLVhQg+mbIoIx9xTCdcoRcR2FTSlQHTfXC2ETg5ivAcUbq6DkgZBTSo2VqEpGdNhV3cVS8t9VZOqkzujnXQGWk3GWZtuzkkD1OpA1SEYCu52wwEHW4+E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748265312; c=relaxed/simple; bh=LGqBJfsp7CSKYrJ68QE9hHsOVObc6hVXMVEeSGXb5II=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sGArD5BqhDNHd7kiLcWYOIWNzkmJo+M5OvM3enHN7KzITQO8gsNUUOexZ96fJmJKBr6k5Wk2SbpktnaUvtW4Jqdd7TPncXjcwtEo8lWGPTQnHJxzwqVwtbdD855W9MKGV9ml7/07VwcHp0nlhIlT8TyDkqSXjI07QFZ/Sm2+32U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=XvToKJH/; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="XvToKJH/" Received: from pendragon.ideasonboard.com (237.69-130-109.adsl-dyn.isp.belgacom.be [109.130.69.237]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 809B0982; Mon, 26 May 2025 15:14:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1748265283; bh=LGqBJfsp7CSKYrJ68QE9hHsOVObc6hVXMVEeSGXb5II=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XvToKJH/r73gmT5Aoee8963n5Og7ULskX02nEtu/HtlFuRZFHzB43NFJ5ZG3PkmMi 9dxro173c9HqGRfC+V7ldepzEfjSZ3ayFgyM2XFj9TpG9GIqN2OgnOcQZgRyRSKJ4r sUKbas+4kLAoG8TjVnjb//Lqoc7pbqkINCkyZHmQ= Date: Mon, 26 May 2025 15:15:02 +0200 From: Laurent Pinchart To: Ricardo Ribalda Cc: Hans de Goede , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] media: uvcvideo: Populate all errors in uvc_probe() Message-ID: <20250526131502.GK17743@pendragon.ideasonboard.com> References: <20250523-uvc-followup-v2-1-487541656e83@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250523-uvc-followup-v2-1-487541656e83@chromium.org> Hi Ricardo, Thank you for the patch. On Fri, May 23, 2025 at 02:28:41PM +0000, Ricardo Ribalda wrote: > Now we are replacing most of the error codes with -ENODEV. > Instead, Populate the error code from the functions called by > uvc_probe(). > > Take this opportunity to replace a generic error code from > uvc_scan_device() into something more meaningful. > > Suggested-by: Laurent Pinchart > Signed-off-by: Ricardo Ribalda Reviewed-by: Laurent Pinchart > --- > CodeStyle and refactor patches after the last uvc Pull Request. > --- > Changes in v2: > - Patches 1-3 will be handled by Laurent: https://lore.kernel.org/linux-media/20250523125840.GG12514@pendragon.ideasonboard.com/ > - Properly propagate ret value. Sorry about that :) > - Link to v1: https://lore.kernel.org/r/20250509-uvc-followup-v1-0-73bcde30d2b5@chromium.org > --- > drivers/media/usb/uvc/uvc_driver.c | 18 +++++++----------- > 1 file changed, 7 insertions(+), 11 deletions(-) > > diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c > index da24a655ab68cc0957762f2b67387677c22224d1..04552da114354128b0cc8fb25e1cc645498ac323 100644 > --- a/drivers/media/usb/uvc/uvc_driver.c > +++ b/drivers/media/usb/uvc/uvc_driver.c > @@ -1866,7 +1866,7 @@ static int uvc_scan_device(struct uvc_device *dev) > > if (list_empty(&dev->chains)) { > dev_info(&dev->udev->dev, "No valid video chain found.\n"); > - return -1; > + return -ENODEV; > } > > /* Add GPIO entity to the first chain. */ > @@ -2239,7 +2239,6 @@ static int uvc_probe(struct usb_interface *intf, > /* Parse the Video Class control descriptor. */ > ret = uvc_parse_control(dev); > if (ret < 0) { > - ret = -ENODEV; > uvc_dbg(dev, PROBE, "Unable to parse UVC descriptors\n"); > goto error; > } > @@ -2275,22 +2274,19 @@ static int uvc_probe(struct usb_interface *intf, > goto error; > > /* Scan the device for video chains. */ > - if (uvc_scan_device(dev) < 0) { > - ret = -ENODEV; > + ret = uvc_scan_device(dev); > + if (ret < 0) > goto error; > - } > > /* Initialize controls. */ > - if (uvc_ctrl_init_device(dev) < 0) { > - ret = -ENODEV; > + ret = uvc_ctrl_init_device(dev); > + if (ret < 0) > goto error; > - } > > /* Register video device nodes. */ > - if (uvc_register_chains(dev) < 0) { > - ret = -ENODEV; > + ret = uvc_register_chains(dev); > + if (ret < 0) > goto error; > - } > > #ifdef CONFIG_MEDIA_CONTROLLER > /* Register the media device node */ > > --- > base-commit: 5e1ff2314797bf53636468a97719a8222deca9ae > change-id: 20250509-uvc-followup-d97ff563df95 -- Regards, Laurent Pinchart