From: Jakub Kicinski <kuba@kernel.org>
To: <jiang.kun2@zte.com.cn>
Cc: <horms@kernel.org>, <kuniyu@amazon.com>, <davem@davemloft.net>,
<edumazet@google.com>, <fan.yu9@zte.com.cn>,
<gnaaman@drivenets.com>, <he.peilin@zte.com.cn>,
<leitao@debian.org>, <linux-kernel@vger.kernel.org>,
<lizetao1@huawei.com>, <netdev@vger.kernel.org>,
<pabeni@redhat.com>, <qiu.yutan@zte.com.cn>,
<tu.qiang35@zte.com.cn>, <wang.yaxin@zte.com.cn>,
<xu.xin16@zte.com.cn>, <yang.yang29@zte.com.cn>,
<ye.xingchen@zte.com.cn>, <zhang.yunkai@zte.com.cn>
Subject: Re: [PATCH linux next v2] net: neigh: use kfree_skb_reason() in neigh_resolve_output() and neigh_connected_output()
Date: Tue, 27 May 2025 18:09:13 -0700 [thread overview]
Message-ID: <20250527180913.4b9f1027@kernel.org> (raw)
In-Reply-To: <20250521101408902uq7XQTEF6fr3v5HKWT2GO@zte.com.cn>
On Wed, 21 May 2025 10:14:08 +0800 (CST) jiang.kun2@zte.com.cn wrote:
> From: Qiu Yutan <qiu.yutan@zte.com.cn>
>
> Replace kfree_skb() used in neigh_resolve_output() and
> neigh_connected_output() with kfree_skb_reason().
>
> Following new skb drop reason is added:
> /* failed to fill the device hard header */
> SKB_DROP_REASON_NEIGH_HH_FILLFAIL
Looks like this got applied already but can you explain for which
protocol you see these drops? I checked random few and none of them
can fail in ->create().
prev parent reply other threads:[~2025-05-28 1:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-21 2:14 jiang.kun2
2025-05-21 23:20 ` Kuniyuki Iwashima
2025-05-22 6:21 ` xu.xin16
2025-05-28 1:09 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250527180913.4b9f1027@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fan.yu9@zte.com.cn \
--cc=gnaaman@drivenets.com \
--cc=he.peilin@zte.com.cn \
--cc=horms@kernel.org \
--cc=jiang.kun2@zte.com.cn \
--cc=kuniyu@amazon.com \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizetao1@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=qiu.yutan@zte.com.cn \
--cc=tu.qiang35@zte.com.cn \
--cc=wang.yaxin@zte.com.cn \
--cc=xu.xin16@zte.com.cn \
--cc=yang.yang29@zte.com.cn \
--cc=ye.xingchen@zte.com.cn \
--cc=zhang.yunkai@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®