mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: David Sterba <dsterba@suse.cz>
Cc: Daniel Vacek <neelx@suse.com>, Chris Mason <clm@fb.com>,
	Josef Bacik <josef@toxicpanda.com>,
	David Sterba <dsterba@suse.com>, Nick Terrell <terrelln@fb.com>,
	linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] btrfs: harden parsing of compress mount option
Date: Thu, 29 May 2025 01:28:49 +0200	[thread overview]
Message-ID: <20250528232848.GM4037@twin.jikos.cz> (raw)
In-Reply-To: <20250424192956.GO3659@twin.jikos.cz>

On Thu, Apr 24, 2025 at 09:29:56PM +0200, David Sterba wrote:
> On Wed, Apr 23, 2025 at 03:22:19PM +0200, Daniel Vacek wrote:
> > Btrfs happily but incorrectly accepts the `-o compress=zlib+foo` and similar
> > options with any random suffix. Let's handle that correctly.
> 
> Please split the patch. Moving code and adding a fix obscures the fix.
> As we'll want to backport more than just the validation of ':' it
> makes more sense to do the full move first and then add the individual
> fixes on top of that. Thanks.

As we've discussed it, both ways how to split it are ok, so please first
factor out the code to a helper and the add the fix or any other
validation that would make sense. Thanks.

      reply	other threads:[~2025-05-28 23:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-23  7:33 [PATCH] " Daniel Vacek
2025-04-23 10:24 ` David Sterba
2025-04-23 10:29 ` David Sterba
2025-04-23 13:22 ` [PATCH v2] " Daniel Vacek
2025-04-24 19:29   ` David Sterba
2025-05-28 23:28     ` David Sterba [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250528232848.GM4037@twin.jikos.cz \
    --to=dsterba@suse.cz \
    --cc=clm@fb.com \
    --cc=dsterba@suse.com \
    --cc=josef@toxicpanda.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neelx@suse.com \
    --cc=terrelln@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®