From: Jessica Zhang <jessica.zhang@oss.qualcomm.com>
To: Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
Marijn Suijten <marijn.suijten@somainline.org>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
Dmitry Baryshkov <lumag@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org,
Stephen Boyd <swboyd@chromium.org>,
Doug Anderson <dianders@chromium.org>,
Johan Hovold <johan@kernel.org>,
Bjorn Andersson <quic_bjorande@quicinc.com>,
Abhinav Kumar <abhinav.kumar@oss.qualcomm.com>,
linux-kernel@vger.kernel.org,
Yongxing Mou <quic_yongmou@quicinc.com>,
Jessica Zhang <jessica.zhang@oss.qualcomm.com>,
Dmitry Baryshkov <lumag@kernel.org>
Subject: [PATCH 3/4] drm/msm/dp: replace ST_DISPLAY_OFF with power_on in msm_dp_hpd_unplug_handle()
Date: Thu, 29 May 2025 16:13:45 -0700 [thread overview]
Message-ID: <20250529-hpd_display_off-v1-3-ce33bac2987c@oss.qualcomm.com> (raw)
In-Reply-To: <20250529-hpd_display_off-v1-0-ce33bac2987c@oss.qualcomm.com>
From: Abhinav Kumar <quic_abhinavk@quicinc.com>
msm_dp_hpd_unplug_handle() checks if the display was already disabled and
if so does not transition to ST_DISCONNECT_PENDING state and goes directly
to ST_DISCONNECTED. The same result can be achieved with the !power_on
check.
Replace ST_DISPLAY_OFF with !power_on to achieve the same outcome.
Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Jessica Zhang <jessica.zhang@oss.qualcomm.com>
---
drivers/gpu/drm/msm/dp/dp_display.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c
index f2820f06f5dc..785c813d2b31 100644
--- a/drivers/gpu/drm/msm/dp/dp_display.c
+++ b/drivers/gpu/drm/msm/dp/dp_display.c
@@ -672,7 +672,7 @@ static int msm_dp_hpd_unplug_handle(struct msm_dp_display_private *dp, u32 data)
*/
msm_dp_display_notify_disconnect(&dp->msm_dp_display.pdev->dev);
- if (state == ST_DISPLAY_OFF) {
+ if (!dp->msm_dp_display.power_on) {
dp->hpd_state = ST_DISCONNECTED;
} else {
dp->hpd_state = ST_DISCONNECT_PENDING;
--
2.49.0
next prev parent reply other threads:[~2025-05-29 23:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-29 23:13 [PATCH 0/4] drm/msm/dp: ST_DISPLAY_OFF hpd cleanup Jessica Zhang
2025-05-29 23:13 ` [PATCH 1/4] drm/msm/dp: remove redundant checks related to ST_DISPLAY_OFF in plug/irq_ipd handlers Jessica Zhang
2025-05-29 23:13 ` [PATCH 2/4] drm/msm/dp: Return early from atomic_enable() if ST_DISCONNECT_PENDING Jessica Zhang
2025-05-30 16:04 ` Dmitry Baryshkov
2025-06-02 17:54 ` Jessica Zhang
2025-06-02 19:47 ` OSS
2025-05-29 23:13 ` Jessica Zhang [this message]
2025-05-29 23:13 ` [PATCH 4/4] drm/msm/dp: remove ST_DISPLAY_OFF as a hpd_state Jessica Zhang
2025-05-30 16:05 ` [PATCH 0/4] drm/msm/dp: ST_DISPLAY_OFF hpd cleanup Dmitry Baryshkov
2025-05-30 17:50 ` Jessica Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250529-hpd_display_off-v1-3-ce33bac2987c@oss.qualcomm.com \
--to=jessica.zhang@oss.qualcomm.com \
--cc=abhinav.kumar@oss.qualcomm.com \
--cc=airlied@gmail.com \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=johan@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_bjorande@quicinc.com \
--cc=quic_yongmou@quicinc.com \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®