mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Masahiro Yamada <masahiroy@kernel.org>
To: linux-kbuild@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Masahiro Yamada <masahiroy@kernel.org>
Subject: [PATCH v2 2/4] scripts/misc-check: add double-quotes to satisfy shellcheck
Date: Sun,  1 Jun 2025 22:31:28 +0900	[thread overview]
Message-ID: <20250601133230.4085512-2-masahiroy@kernel.org> (raw)
In-Reply-To: <20250601133230.4085512-1-masahiroy@kernel.org>

In scripts/misc-check line 8:
        git -C ${srctree:-.} ls-files -i -c --exclude-per-directory=.gitignore 2>/dev/null |
               ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---

Changes in v2:
 - New patch

 scripts/misc-check | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/misc-check b/scripts/misc-check
index f37b2f6931cc..21551d721079 100755
--- a/scripts/misc-check
+++ b/scripts/misc-check
@@ -5,7 +5,7 @@ set -e
 
 # Detect files that are tracked but ignored by git.
 check_tracked_ignored_files () {
-	git -C ${srctree:-.} ls-files -i -c --exclude-per-directory=.gitignore 2>/dev/null |
+	git -C "${srctree:-.}" ls-files -i -c --exclude-per-directory=.gitignore 2>/dev/null |
 		sed 's/$/: warning: ignored by one of the .gitignore files/' >&2
 }
 
-- 
2.43.0


  reply	other threads:[~2025-06-01 13:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-01 13:31 [PATCH v2 1/4] kbuild: move W=1 check for scripts/misc-check to top-level Makefile Masahiro Yamada
2025-06-01 13:31 ` Masahiro Yamada [this message]
2025-06-01 13:31 ` [PATCH v2 3/4] scripts/misc-check: check missing #include <linux/export.h> when W=1 Masahiro Yamada
2025-06-04  4:52   ` Masahiro Yamada
2025-06-19 16:01   ` Jakub Kicinski
2025-06-19 16:13     ` Masahiro Yamada
2025-06-19 16:26       ` Jakub Kicinski
2025-06-01 13:31 ` [PATCH v2 4/4] scripts/misc-check: check unnecessary " Masahiro Yamada
2025-06-02 22:06 ` [PATCH v2 1/4] kbuild: move W=1 check for scripts/misc-check to top-level Makefile Nathan Chancellor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250601133230.4085512-2-masahiroy@kernel.org \
    --to=masahiroy@kernel.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®