From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 14E5532EAB3; Sun, 1 Jun 2025 23:43:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748821420; cv=none; b=FPjHznRWrHSsUEItbDewOFMcwmK2pQ7iCOKRp2sGZhjpZdrE/cov49gmPiFB9xUiZo8rh/3L4RhKzdzVna+n6KwUdRat0JB1q02DovBjJzoGUoIce9QbhS1yV8725Vs1KwGUWxVobKrG4sOP2itgHkgejAHbMesq0ZiwT/l8fdE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748821420; c=relaxed/simple; bh=O91ereYx5iIBua8eKP+EPQmtDV3bSnt27ufgiRIv6ts=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=EfWLAkyGy/u9SM8vYkY3I08t6JaufpilOZLbFDogXA8UVkp2/Kc+eQ3pgXVKRV39Sa44etgILjG0c3tCGpufw8m0Bf2M+mzB4N+xEcz46XtiocxGaQFNTq4Fpf9C+ldAix+t4TtDRvPDKJdF7w3pnRIplvTVdAnxxFTne+MRUpU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BCIDiAQE; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BCIDiAQE" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A9647C4CEF3; Sun, 1 Jun 2025 23:43:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1748821419; bh=O91ereYx5iIBua8eKP+EPQmtDV3bSnt27ufgiRIv6ts=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BCIDiAQEZXM1EdC619OOFjNRzXwzmSNWZAlXR5KDsso6SfCYQwudUCpb3vZiD9KBp hMr+jmU0sKr95NbxjaRC1KAKaZkfSLvBlxZZg+0yJvyE48iKnHwLJ61K+53z1pvO5t w3ZWbuC4qrzkXEvjJlS4wQ+1ySQddcl3pYWjmPOjJ1le+TdSkROWyERTv53wIuofM3 Px/7bYM5ShTzVPsMXe6hVCOgV9j+8KxfLx/dQMv3p6A75Gfu0lDrWD3z5qI7B1IkM5 6tb2vnOph/S8Vkjyutej5X42r3O2bhz2wEEyLFHKamcoPgGQRRJY430T/o7KyZU4ia vlqi8JHQbxLow== From: Sasha Levin To: patches@lists.linux.dev, stable@vger.kernel.org Cc: Armin Wolf , "Rafael J . Wysocki" , Sasha Levin , rafael@kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH AUTOSEL 5.15 33/43] ACPI: bus: Bail out if acpi_kobj registration fails Date: Sun, 1 Jun 2025 19:42:13 -0400 Message-Id: <20250601234224.3517599-33-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250601234224.3517599-1-sashal@kernel.org> References: <20250601234224.3517599-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.15.184 Content-Transfer-Encoding: 8bit From: Armin Wolf [ Upstream commit 94a370fc8def6038dbc02199db9584b0b3690f1a ] The ACPI sysfs code will fail to initialize if acpi_kobj is NULL, together with some ACPI drivers. Follow the other firmware subsystems and bail out if the kobject cannot be registered. Signed-off-by: Armin Wolf Link: https://patch.msgid.link/20250518185111.3560-2-W_Armin@gmx.de Signed-off-by: Rafael J. Wysocki Signed-off-by: Sasha Levin --- **YES** This commit should be backported to stable kernel trees. Here's the detailed analysis: **Bug Fix Nature**: The commit fixes a real bug where ACPI initialization continues silently even when `acpi_kobj` registration fails. This creates an inconsistent system state where ACPI sysfs functionality and some drivers that depend on `acpi_kobj` will fail later without clear indication of the root cause. **Code Change Analysis**: - Changes `pr_debug()` to `pr_err()` for better visibility of the failure - Returns `-ENOMEM` immediately when `kobject_create_and_add()` fails instead of continuing - The existing `kobject_put(acpi_kobj)` cleanup in the error path after `acpi_bus_init()` is already present **Comparison with Similar Commits**: This follows the exact pattern of Similar Commit #1 (Status: YES) which added `kobject_put()` cleanup. Both commits address resource management issues in the same function (`acpi_init`) and represent important bugfixes with minimal risk. **Risk Assessment**: - Very low risk - only affects the error path when kobject creation fails - Early failure is better than silent failure leading to confusing symptoms later - Change is contained to a single function with clear error handling - Consistent with how other firmware subsystems handle kobject registration failures **Stable Tree Criteria Met**: - Fixes important bug affecting system reliability - Minimal and contained change - No architectural modifications - Clear improvement in error handling and debugging The commit addresses a legitimate reliability issue where ACPI would continue initialization with a NULL `acpi_kobj`, leading to failures in dependent subsystems that would be harder to diagnose than an early, clear failure. drivers/acpi/bus.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c index 9bc5bc5bc359b..ea63b8f272892 100644 --- a/drivers/acpi/bus.c +++ b/drivers/acpi/bus.c @@ -1335,8 +1335,10 @@ static int __init acpi_init(void) } acpi_kobj = kobject_create_and_add("acpi", firmware_kobj); - if (!acpi_kobj) - pr_debug("%s: kset create error\n", __func__); + if (!acpi_kobj) { + pr_err("Failed to register kobject\n"); + return -ENOMEM; + } init_prmt(); result = acpi_bus_init(); -- 2.39.5