mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: daniel.lezcano@linaro.org, tglx@linutronix.de
Cc: Jim Cromie <jim.cromie@gmail.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Chen-Yu Tsai <wens@csie.org>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Samuel Holland <samuel@sholland.org>,
	Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	"Peter Zijlstra (Intel)" <peterz@infradead.org>,
	Marco Elver <elver@google.com>, Nam Cao <namcao@linutronix.de>,
	linux-kernel@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org,
	linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org,
	John Stulz <jstultz@google.com>,
	Will McVicker <willmcvicker@google.com>,
	Peter Griffin <peter.griffin@linaro.org>,
	Saravan Kanna <saravanak@google.com>
Subject: [PATCH v1 6/7] clocksource/drivers/cs5535: Add module owner
Date: Mon,  2 Jun 2025 17:18:50 +0200	[thread overview]
Message-ID: <20250602151853.1942521-7-daniel.lezcano@linaro.org> (raw)
In-Reply-To: <20250602151853.1942521-1-daniel.lezcano@linaro.org>

The conversion to modules requires a correct handling of the module
refcount in order to prevent to unload it if it is in use. That is
especially true with the clockevents where there is no function to
unregister them.

The core time framework correctly handles the module refcount with the
different clocksource and clockevents if the module owner is set.

Add the module owner to make sure the core framework will prevent
stupid things happening when the driver will be converted into a
module.

Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
 drivers/clocksource/timer-cs5535.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clocksource/timer-cs5535.c b/drivers/clocksource/timer-cs5535.c
index d47acfe848ae..8af666c39890 100644
--- a/drivers/clocksource/timer-cs5535.c
+++ b/drivers/clocksource/timer-cs5535.c
@@ -101,6 +101,7 @@ static struct clock_event_device cs5535_clockevent = {
 	.tick_resume = mfgpt_shutdown,
 	.set_next_event = mfgpt_next_event,
 	.rating = 250,
+	.owner = THIS_MODULE,
 };
 
 static irqreturn_t mfgpt_tick(int irq, void *dev_id)
-- 
2.43.0


  parent reply	other threads:[~2025-06-02 15:19 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-02 15:18 [PATCH v1 0/7] Setting the scene to convert the timers into modules Daniel Lezcano
2025-06-02 15:18 ` [PATCH v1 1/7] clocksource/drivers/scx200: Add module owner Daniel Lezcano
2025-06-03 17:48   ` William McVicker
2025-07-23  7:17   ` [tip: timers/clocksource] " tip-bot2 for Daniel Lezcano
2025-07-25 10:31   ` tip-bot2 for Daniel Lezcano
2025-06-02 15:18 ` [PATCH v1 2/7] clocksource/drivers/stm32-lp: " Daniel Lezcano
2025-06-03 17:54   ` William McVicker
2025-07-23  7:17   ` [tip: timers/clocksource] " tip-bot2 for Daniel Lezcano
2025-07-25 10:31   ` tip-bot2 for Daniel Lezcano
2025-06-02 15:18 ` [PATCH v1 3/7] clocksource/drivers/sun5i: " Daniel Lezcano
2025-06-03  4:41   ` Chen-Yu Tsai
2025-06-03 17:55   ` William McVicker
2025-07-23  7:17   ` [tip: timers/clocksource] " tip-bot2 for Daniel Lezcano
2025-07-25 10:31   ` tip-bot2 for Daniel Lezcano
2025-06-02 15:18 ` [PATCH v1 4/7] clocksource/drivers/tegra186: " Daniel Lezcano
2025-06-03 17:57   ` William McVicker
2025-07-23  7:17   ` [tip: timers/clocksource] " tip-bot2 for Daniel Lezcano
2025-07-25 10:31   ` tip-bot2 for Daniel Lezcano
2025-06-02 15:18 ` [PATCH v1 5/7] clocksource/drivers/stm: " Daniel Lezcano
2025-06-03 17:59   ` William McVicker
2025-07-23  7:17   ` [tip: timers/clocksource] " tip-bot2 for Daniel Lezcano
2025-07-25 10:31   ` tip-bot2 for Daniel Lezcano
2025-06-02 15:18 ` Daniel Lezcano [this message]
2025-06-03 18:00   ` [PATCH v1 6/7] clocksource/drivers/cs5535: " William McVicker
2025-07-23  7:17   ` [tip: timers/clocksource] " tip-bot2 for Daniel Lezcano
2025-07-25 10:31   ` tip-bot2 for Daniel Lezcano
2025-06-02 15:18 ` [PATCH v1 7/7] time: Export symbol for sched_clock register function Daniel Lezcano
2025-06-03 18:01   ` William McVicker
2025-06-04  3:43   ` John Stultz
2025-06-04  9:25   ` Thomas Gleixner
2025-07-23  7:17   ` [tip: timers/clocksource] time/sched_clock: " tip-bot2 for Daniel Lezcano
2025-07-25 10:31   ` [tip: timers/clocksource] time/sched_clock: Export symbol for sched_clock_register() function tip-bot2 for Daniel Lezcano
2025-06-03 18:04 ` [PATCH v1 0/7] Setting the scene to convert the timers into modules William McVicker
2025-08-13 13:00 ` Daniel Lezcano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250602151853.1942521-7-daniel.lezcano@linaro.org \
    --to=daniel.lezcano@linaro.org \
    --cc=alexandre.torgue@foss.st.com \
    --cc=elver@google.com \
    --cc=jernej.skrabec@gmail.com \
    --cc=jim.cromie@gmail.com \
    --cc=jonathanh@nvidia.com \
    --cc=jstultz@google.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=namcao@linutronix.de \
    --cc=peter.griffin@linaro.org \
    --cc=peterz@infradead.org \
    --cc=samuel@sholland.org \
    --cc=saravanak@google.com \
    --cc=tglx@linutronix.de \
    --cc=thierry.reding@gmail.com \
    --cc=wens@csie.org \
    --cc=willmcvicker@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®