From: Peter Zijlstra <peterz@infradead.org>
To: Luo Gengkun <luogengkun@huaweicloud.com>
Cc: mingo@redhat.com, acme@kernel.org, namhyung@kernel.org,
mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com,
kan.liang@linux.intel.com, davidcc@google.com,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] perf/core: Fix nr_cgroups/cpuctx->cgrp is not updated correctly
Date: Wed, 4 Jun 2025 11:19:36 +0200 [thread overview]
Message-ID: <20250604091936.GG38114@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20250604033924.3914647-2-luogengkun@huaweicloud.com>
On Wed, Jun 04, 2025 at 03:39:23AM +0000, Luo Gengkun wrote:
> Since __perf_remove_from_context updates event->state before
> list_del_event, this prevents list_del_event from calling
> perf_cgroup_event_disable, resulting in will not update nr_cgroups and
> cpuctx->cgrp.
>
> To fix this problem, move perf_cgroup_event_disable into
> __perf_remove_from_context as:
>
> commit a3c3c66670ce ("perf/core: Fix child_total_time_enabled accounting bug at task exit")
>
> did.
>
> Fixes: a3c3c66670ce ("perf/core: Fix child_total_time_enabled accounting bug at task exit")
> Signed-off-by: Luo Gengkun <luogengkun@huaweicloud.com>
So I already have Yeoreum's patch for this:
https://lkml.kernel.org/r/20250603144414.GC38114@noisy.programming.kicks-ass.net
next prev parent reply other threads:[~2025-06-04 9:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-04 3:39 [PATCH v2 0/2] Fix perf cgroup problem Luo Gengkun
2025-06-04 3:39 ` [PATCH v2 1/2] perf/core: Fix nr_cgroups/cpuctx->cgrp is not updated correctly Luo Gengkun
2025-06-04 9:19 ` Peter Zijlstra [this message]
2025-06-04 9:42 ` Luo Gengkun
2025-06-04 3:39 ` [PATCH v2 2/2] perf/core: Fix WARN_ON_ONCE(cpuctx->ctx.nr_cgroups == 0) in perf_cgroup_switch Luo Gengkun
2025-06-04 10:00 ` Peter Zijlstra
2025-06-05 3:55 ` Luo Gengkun
2025-06-05 7:36 ` Peter Zijlstra
2025-06-11 9:29 ` [tip: perf/urgent] perf/core: Fix WARN in perf_cgroup_switch() tip-bot2 for Luo Gengkun
2025-06-26 13:08 ` Luo Gengkun
2025-06-26 13:13 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250604091936.GG38114@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=davidcc@google.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=luogengkun@huaweicloud.com \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®