From: Yury Norov <yury.norov@gmail.com>
To: Douglas Anderson <dianders@chromium.org>,
"Yury Norov [NVIDIA]" <yury.norov@gmail.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH] watchdog: fix opencoded cpumask_next_wrap() in watchdog_next_cpu()
Date: Wed, 4 Jun 2025 20:12:52 -0400 [thread overview]
Message-ID: <20250605001253.46084-1-yury.norov@gmail.com> (raw)
From: Yury Norov [NVIDIA] <yury.norov@gmail.com>
The dedicated helper is more verbose and efficient comparing to
cpumask_next() followed by cpumask_first().
Signed-off-by: Yury Norov [NVIDIA] <yury.norov@gmail.com>
---
kernel/watchdog_buddy.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/kernel/watchdog_buddy.c b/kernel/watchdog_buddy.c
index 34dbfe091f4b..ee754d767c21 100644
--- a/kernel/watchdog_buddy.c
+++ b/kernel/watchdog_buddy.c
@@ -12,10 +12,7 @@ static unsigned int watchdog_next_cpu(unsigned int cpu)
{
unsigned int next_cpu;
- next_cpu = cpumask_next(cpu, &watchdog_cpus);
- if (next_cpu >= nr_cpu_ids)
- next_cpu = cpumask_first(&watchdog_cpus);
-
+ next_cpu = cpumask_next_wrap(cpu, &watchdog_cpus);
if (next_cpu == cpu)
return nr_cpu_ids;
--
2.43.0
next reply other threads:[~2025-06-05 0:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-05 0:12 Yury Norov [this message]
2025-06-09 17:16 ` Doug Anderson
2025-06-21 14:58 ` Yury Norov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250605001253.46084-1-yury.norov@gmail.com \
--to=yury.norov@gmail.com \
--cc=dianders@chromium.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®