From: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
To: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
Cc: Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"michal.simek@amd.com" <michal.simek@amd.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"git@amd.com" <git@amd.com>
Subject: Re: [PATCH] usb: dwc3: xilinx: add shutdown callback
Date: Thu, 5 Jun 2025 00:23:30 +0000 [thread overview]
Message-ID: <20250605002326.lbv2ltj2nfqj7s3u@synopsys.com> (raw)
In-Reply-To: <1748977771-714153-1-git-send-email-radhey.shyam.pandey@amd.com>
On Wed, Jun 04, 2025, Radhey Shyam Pandey wrote:
> Adds a shutdown callback to ensure that the XHCI stack is properly
> shutdown in reboot/shutdown path.
>
> In kexec flow, kernel_restart_prepare() performs actions necessary
> to prepare the system for a restart and invokes device_shutdown. To
> ensure proper shutdown attach the dwc3 shutdown implementation which
> mirrors the remove method.
>
> $ kexec -e
>
> <snip>
> xhci-hcd xhci-hcd.0.auto: remove, state 1
> usb usb1: USB disconnect, device number 1
> usb 1-1: USB disconnect, device number 6
> xhci-hcd xhci-hcd.0.auto: USB bus 1 deregistered
> kexec_core: Starting new kernel
>
> Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
> ---
> Referred implementation from mainline commit ' 85e8a23936ab
> ("scsi: lpfc: Add shutdown method for kexec").
> ---
> drivers/usb/dwc3/dwc3-xilinx.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/dwc3/dwc3-xilinx.c b/drivers/usb/dwc3/dwc3-xilinx.c
> index 4ca7f6240d07..09c3c5c226ab 100644
> --- a/drivers/usb/dwc3/dwc3-xilinx.c
> +++ b/drivers/usb/dwc3/dwc3-xilinx.c
> @@ -422,6 +422,7 @@ static const struct dev_pm_ops dwc3_xlnx_dev_pm_ops = {
> static struct platform_driver dwc3_xlnx_driver = {
> .probe = dwc3_xlnx_probe,
> .remove = dwc3_xlnx_remove,
> + .shutdown = dwc3_xlnx_remove,
> .driver = {
> .name = "dwc3-xilinx",
> .of_match_table = dwc3_xlnx_of_match,
>
> base-commit: a0bea9e39035edc56a994630e6048c8a191a99d8
> --
> 2.34.1
>
Acked-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
BR,
Thinh
prev parent reply other threads:[~2025-06-05 0:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-03 19:09 Radhey Shyam Pandey
2025-06-05 0:23 ` Thinh Nguyen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250605002326.lbv2ltj2nfqj7s3u@synopsys.com \
--to=thinh.nguyen@synopsys.com \
--cc=git@amd.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=radhey.shyam.pandey@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®