From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f46.google.com (mail-qv1-f46.google.com [209.85.219.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CFB0520C026 for ; Thu, 5 Jun 2025 12:09:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749125361; cv=none; b=WS0EaA4PdqU2DaiZk8zbIrOEhYHFbhxYD2eGpzf7EUugFQaXRprG0P/f+SxP/6cwkx34vIUEhDI8wqK7Wb1EG+6FeR8HX7QJsoGGdbkEwxD+NDgDSUhPuBglY/MZqXpR8Znz5YsURI6NDsPbSB/2dGzzXHmXQis6NLncwrx13LA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749125361; c=relaxed/simple; bh=68ST4wWru6aYFudYB/AR3+klXokvG7WPyNYVacGmxco=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hbhSqqohQsUIQu7/iBdxUmwia8ps++LWIgDx+6AwoiCftjQ/c6vLs59znzMMmlcLPKCCt9c+T1sKzB1iBKyYD8gnsSTP6K6t6vTN2Ni7W0mmWHKgd2utftjYWb1Zrw7SoZ66abRC9+OTwAmFjcQjMhShlOW0pAt2WbvrwCxSh7w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=I0osl0hl; arc=none smtp.client-ip=209.85.219.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="I0osl0hl" Received: by mail-qv1-f46.google.com with SMTP id 6a1803df08f44-6fad8b4c927so8103966d6.0 for ; Thu, 05 Jun 2025 05:09:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1749125359; x=1749730159; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=UNA1AqJPiuiUBzCeRC8bK1nu38f0qCHlYuwt9uDWl+g=; b=I0osl0hlt4Wb/cImSyn7xpSmr1foyB4eyd+a5FZJdcMpmq0atJGB7StBZyENYtbAjo bW9cIyQRYLE53n7QdQ0yCDv19KXYNITb/IYQrJjtsgDwbvT6v3/Lw3PgwRTn5tPV3kYt A7XvI7/W8ynRihhAmKIuK0j+T4HbrSOTDRAopm1PiPY75dAyj0Jn90+7bfFi3b7yO4Qn bgCJIxdvpy3cwdSFVbvKNbb3SLTQRJ2NzhraEow1wJZzkTTPkccKIRfm6Qkfx47gBD69 xzE4vscJt+NJLa9s5APp6AdsiUhZpUTeUHLdl91VJIXOafhwkbWfRRJTmPFHWGE9BXem aijw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749125359; x=1749730159; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UNA1AqJPiuiUBzCeRC8bK1nu38f0qCHlYuwt9uDWl+g=; b=MNnVULUzMVgG6UtD3oVyApFabvQ0ocoD5eVL/LBYNLLFgttztFx0tHGc6Ax6sBPT6x p1XEsNKC7UDxeOhYVdQ9R7DJFrXeCNWv8MsU0NSnrCXp+B714vEoAxYOIJoXdc6mQntG a0d2eUJGU1LSmjHeP/vnOy5tTnCuh7CXT21fbQfiEl0TfqR52zZ7A2/tW523bRwzAiEC 2swNpKVAar7hwRICZhUtmUxH1f1fnOvpkItBvjig+sCcyVS8cm30GpRDLKy0IkTgszDR pt/b4YQhNGQuEciAIGvMTjP1O6ALdd73eXpmsIvn4EVMZkEou3jXnsbcHL/Hddr4FRtY rrKQ== X-Forwarded-Encrypted: i=1; AJvYcCXe5pkPrHjgkuVi+nAbqt12A39md7s5bMGiQh1DIcREdDzwpXWvSdhXgtc7Mb6iJQ3gw1skFpp0Oh62JNg=@vger.kernel.org X-Gm-Message-State: AOJu0YzFEI3KrfJXksaVBNnKQfmOKuJbVrk1ayfO00+GQBkd0x7bxob7 IR3LjrwakeSK7QBz4fPQGKH7aWWLtU02YsWUCq2IRRBDaNIOL73SI4tLBYx2JU1oK6k= X-Gm-Gg: ASbGncsjVHkyedScWS5haF6vWIqmE2Svaqg9k/6lxcGF3ftpdIt5RPO7DBjIOV+aAyA bQrgNL5JoFQM2oGInkheodmvZJzD0eoa6sI+D4gfe4hmxHBGU4sO7olbOnL7D63jkYMiAxZ7yjz t+H0/A+0TQOj+BJyJ90DFNk/R7kbtLbZ50pKoDjr+15WIGlVUYix97pLqn/d11XhKOuWQlsvm+X 85pH+ts3tQQN2VXj+nNaOFfRWrVAYV1TmUwZ34ZoQyekQb2jFZhQyx/5Bs15Bw/vQ+qFVmzX4Ec ObjFqz3w4M6w/zEjSD146dTkuT68AE3R2NGYysqeRaj15Y+oH8yxryaQsu5OsU+mQhYW5aUmIp4 CCQJs3oAygIFphgpJEPCDC4t1ym0= X-Google-Smtp-Source: AGHT+IGoKm/5U4/UM2uM64qO2HBitYJapsKbuDFJlmk9byEyE/W8ROsmev/IR9V9jeal6LfHAI1O8g== X-Received: by 2002:a05:6214:224d:b0:6fa:c512:c401 with SMTP id 6a1803df08f44-6faf70163f2mr115317766d6.37.1749125350351; Thu, 05 Jun 2025 05:09:10 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-167-56-70.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.167.56.70]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6fac6d4c7d8sm120604836d6.36.2025.06.05.05.09.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Jun 2025 05:09:09 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1uN9PB-00000000EdT-18gz; Thu, 05 Jun 2025 09:09:09 -0300 Date: Thu, 5 Jun 2025 09:09:09 -0300 From: Jason Gunthorpe To: Dan Williams Cc: Alistair Popple , linux-mm@kvack.org, gerald.schaefer@linux.ibm.com, willy@infradead.org, david@redhat.com, linux-kernel@vger.kernel.org, nvdimm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, jhubbard@nvidia.com, hch@lst.de, zhang.lyra@gmail.com, debug@rivosinc.com, bjorn@kernel.org, balbirs@nvidia.com, lorenzo.stoakes@oracle.com, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-cxl@vger.kernel.org, dri-devel@lists.freedesktop.org, John@groves.net Subject: Re: [PATCH 07/12] mm: Remove redundant pXd_devmap calls Message-ID: <20250605120909.GA44681@ziepe.ca> References: <2ee5a64581d2c78445e5c4180d7eceed085825ca.1748500293.git-series.apopple@nvidia.com> <6841026c50e57_249110022@dwillia2-xfh.jf.intel.com.notmuch> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6841026c50e57_249110022@dwillia2-xfh.jf.intel.com.notmuch> On Wed, Jun 04, 2025 at 07:35:24PM -0700, Dan Williams wrote: > If all dax pages are special, then vm_normal_page() should never find > them and gup should fail. > > ...oh, but vm_normal_page_p[mu]d() is not used in the gup path, and > 'special' is not set in the pte path. That seems really suboptimal?? Why would pmd and pte be different? > I think for any p[mu]d where p[mu]d_page() is ok to use should never set > 'special', right? There should be dedicated functions for installing pages and PFNs, only the PFN one would set the special bit. And certainly your tests *should* be failing as special entries should never ever be converted to struct page. Jason