mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: John Fastabend <john.fastabend@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	netdev <netdev@vger.kernel.org>,
	Jonathan Lemon <jonathan.lemon@gmail.com>,
	Jesper Dangaard Brouer <hawk@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>
Subject: Re: [for-linus][PATCH 3/5] xdp: Remove unused mem_return_failed event
Date: Thu, 5 Jun 2025 07:27:30 -0700	[thread overview]
Message-ID: <20250605142730.wv5rsc4eg6ynwpga@gmail.com> (raw)
In-Reply-To: <20250603171228.762591654@goodmis.org>

On 2025-06-03 13:11:52, Steven Rostedt wrote:
> From: Steven Rostedt <rostedt@goodmis.org>
> 
> The change to allow page_pool to handle its own page destruction instead
> of relying on XDP removed the trace_mem_return_failed() tracepoint caller,
> but did not remove the mem_return_failed trace event. As trace events take
> up memory when they are created regardless of if they are used or not,
> having this unused event around wastes around 5K of memory.
> 
> Remove the unused event.
> 
> Link: https://lore.kernel.org/all/20250529130138.544ffec4@gandalf.local.home/
> 
> Cc: netdev <netdev@vger.kernel.org>
> Cc: Jonathan Lemon <jonathan.lemon@gmail.com>
> Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
> Cc: Masami Hiramatsu <mhiramat@kernel.org>
> Link: https://lore.kernel.org/20250529160550.1f888b15@gandalf.local.home
> Fixes: c3f812cea0d7 ("page_pool: do not release pool until inflight == 0.")
> Acked-by: Jesper Dangaard Brouer <hawk@kernel.org>
> Acked-by: Jakub Kicinski <kuba@kernel.org>
> Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
> ---
>  include/trace/events/xdp.h | 26 --------------------------
>  1 file changed, 26 deletions(-)

Reviewed-by: John Fastabend <john.fastabend@gmail.com>

  reply	other threads:[~2025-06-05 14:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-03 17:11 [for-linus][PATCH 0/5] tracing: Fixes for v6.16 Steven Rostedt
2025-06-03 17:11 ` [for-linus][PATCH 1/5] ftrace: Fix UAF when lookup kallsym after ftrace disabled Steven Rostedt
2025-06-03 17:11 ` [for-linus][PATCH 2/5] ftrace: Dont allocate ftrace module map if ftrace is disabled Steven Rostedt
2025-06-03 17:11 ` [for-linus][PATCH 3/5] xdp: Remove unused mem_return_failed event Steven Rostedt
2025-06-05 14:27   ` John Fastabend [this message]
2025-06-03 17:11 ` [for-linus][PATCH 4/5] genirq/matrix: Remove unused irq_matrix_alloc_reserved tracepoint Steven Rostedt
2025-06-03 17:11 ` [for-linus][PATCH 5/5] fsdax: Remove unused trace events for dax insert mapping Steven Rostedt
2025-06-03 18:13   ` Dan Williams
2025-06-03 19:19     ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250605142730.wv5rsc4eg6ynwpga@gmail.com \
    --to=john.fastabend@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=hawk@kernel.org \
    --cc=jonathan.lemon@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®