mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: John Garry <john.g.garry@oracle.com>
To: agk@redhat.com, snitzer@kernel.org, mpatocka@redhat.com,
	song@kernel.org, yukuai3@huawei.com, hch@lst.de,
	nilay@linux.ibm.com, axboe@kernel.dk
Cc: dm-devel@lists.linux.dev, linux-kernel@vger.kernel.org,
	linux-raid@vger.kernel.org, linux-block@vger.kernel.org,
	ojaswin@linux.ibm.com, martin.petersen@oracle.com,
	John Garry <john.g.garry@oracle.com>
Subject: [PATCH RFC 0/4] block: set chunk_sectors from stacked dev stripe size
Date: Thu,  5 Jun 2025 15:08:53 +0000	[thread overview]
Message-ID: <20250605150857.4061971-1-john.g.garry@oracle.com> (raw)

Currently md raid0/10 and dm-stripe sets io_min limit from stripe width.

This value in io_min is used to configure any atomic write limit for the
stacked device. The idea is that the atomic write unit max is a
power-of-2 factor of the stripe width.

Using io_min causes issues, as:
a. it may be mutated
b. the check for io_min being set for determining if we are dealing with
a striped device is hard to get right, as reported in [0].

This series now sets chunk_sectors limit to share stripe size.

Sending as an RFC as I need to test more and I am not totally confident
that using chunk_sectors is the right approach.

Apologies for any delays in response, as I will be OoO soon, and I
wanted to send this to share with Nilay.

[0] https://lore.kernel.org/linux-block/888f3b1d-7817-4007-b3b3-1a2ea04df771@linux.ibm.com/T/#mecca17129f72811137d3c2f1e477634e77f06781

John Garry (4):
  md/raid0: set chunk_sectors limit
  md/raid10: set chunk_sectors limit
  dm-stripe: limit chunk_sectors to the stripe size
  block: use chunk_sectors when evaluating stacked atomic write limits

 block/blk-settings.c          | 8 +++++---
 drivers/md/dm-stripe.c        | 3 ++-
 drivers/md/dm-table.c         | 4 ++++
 drivers/md/raid0.c            | 1 +
 drivers/md/raid10.c           | 1 +
 include/linux/device-mapper.h | 3 +++
 6 files changed, 16 insertions(+), 4 deletions(-)

-- 
2.31.1


             reply	other threads:[~2025-06-05 15:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-05 15:08 John Garry [this message]
2025-06-05 15:08 ` [PATCH RFC 1/4] md/raid0: set chunk_sectors limit John Garry
2025-06-05 15:08 ` [PATCH RFC 2/4] md/raid10: " John Garry
2025-06-05 15:08 ` [PATCH RFC 3/4] dm-stripe: limit chunk_sectors to the stripe size John Garry
2025-06-06 15:16   ` Nilay Shroff
2025-06-12 10:01     ` John Garry
2025-06-09 15:19   ` Mikulas Patocka
2025-06-12  9:15     ` John Garry
2025-06-05 15:08 ` [PATCH RFC 4/4] block: use chunk_sectors when evaluating stacked atomic write limits John Garry
2025-06-06 15:23   ` Nilay Shroff
2025-06-12  9:17     ` John Garry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250605150857.4061971-1-john.g.garry@oracle.com \
    --to=john.g.garry@oracle.com \
    --cc=agk@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=dm-devel@lists.linux.dev \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=mpatocka@redhat.com \
    --cc=nilay@linux.ibm.com \
    --cc=ojaswin@linux.ibm.com \
    --cc=snitzer@kernel.org \
    --cc=song@kernel.org \
    --cc=yukuai3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®