From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE33219CD1B for ; Thu, 5 Jun 2025 18:32:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749148331; cv=none; b=Wq+urJ4LsxX5PBkFj2U6TlQ/F0fyVBMpXI1UZxefceUkr6av0CZfAS7wG4bDvKwYrMd4ujEDT+e0g0WKZacgtBvjeVTp9qxOssPwb9/6v8Z2HbfPA8CHKJXuuf4yIwJMBOI+vy3zKrL2yjQ262JLNRbS8SMeaRlN7U4MjNdTbtY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749148331; c=relaxed/simple; bh=819nSBPoIuWMydruyeOciA20s0lPu+TSZhECeNKmWZA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=nvYTTtR1RhyKaH/UytacKwgEDoKxWRz19BHOCD/uFYFASqG9yDf6fGb95Ld0dg68UQ5Js3x7aCmG3xHNZ2qzwLkR4BIPsGsg+tNQ+eXcZsU9ok8q7wQL8vNYxia4VE2nihUU9vd3bGN0u1CKDOJFIET7r7PBJSdM0CP7kmL/YgU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=HuFgLxs4; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="HuFgLxs4" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 555H6VQo024416 for ; Thu, 5 Jun 2025 18:32:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=qcppdkim1; bh=EbkEQB58Ld4nL18JV6VryQl6iNajcUl8L84 E7nzQctY=; b=HuFgLxs45bFXN3TASiM9MayDYeBJFMD7eulzvKG59uiguFE40JL MhXF/4ZIC6N/cni+NUmuZJhkLglT/+HBz0Ze9oY7cFfT7oEvOLdFrFGx+dHfA4qC Bb5fnlk7ab15bsDpIzWzMeSFliDQNfa4yQk5cEeoU6kmUqXHsLxGvU147LDqe6Vl PHyZiZh7agujSbk3uO3bxKHM7uezWPBwJxtbmB6Qq9WaxMfWwdkXes/pETisIxTu jnwONT7KI+d01Hy+zFGf4LwbqFIZNlfOtk8zLvRNA01FA2z+EfVq3cnlMZrkh39f cAuxx6hILAe2jY1rVajzZfDJs19zxlWaa/Q== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 471g8s2c2c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 05 Jun 2025 18:32:08 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2355651d204so11988415ad.2 for ; Thu, 05 Jun 2025 11:32:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749148328; x=1749753128; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=EbkEQB58Ld4nL18JV6VryQl6iNajcUl8L84E7nzQctY=; b=btgWVymGsTsMIUt15QGbW/ZP8r+TSRtBn/ycgUezMYZps+/CxoW4oYPHcheWlz+CoR jdEQ7901vN6vgdfSLRy3BlRbU810NhC7ZeCKqYpbYM6aBozUJiTPdaZY/Ku4oCZw0DXY qhTAYBc9jBn8nsaChiKbuRVuYhLq7sUypoPAJ0WEaYvcjiThkh15zCV5M3l/C3JILJBW zy0pymaIFAVSSNE7lfCK7Az/Sz4/LnFF1k1SAyiakA3zTnMfibDDp0F8qnvdoHhXGaNA kmTg/IQO32FiUsxzFMbk70Z2HX0+tcbotffMK1Aj9qy5YQ4T3KjWD75oFTH/S6MdoBp7 q/eQ== X-Forwarded-Encrypted: i=1; AJvYcCV8mFX13baJj/gU7UWezxxH7IrAZvRDruasIGM0l7CWxykmqrdeCcqyr/t9StgiqtZlt2kg0+xAUy6XhcU=@vger.kernel.org X-Gm-Message-State: AOJu0YyBvKAGnS8mzAFTUmmTXCiQujdzlfAI0ceuNN+sJ+gXn+5nHEh2 cVhTzVhv+gV8g1So8fdATXI/ZZDl2eh6lITDqagz1+kbmxH2NgizEKt7oDjCorNUbSXrjxciISm V9ltDLsuE8c/61yyYlHsimEhEI2O1i9eocnWeAH9yDqynxDd6n8j2QOrn/9SPO3M40nk= X-Gm-Gg: ASbGncu4LpcEqL6DSCKWmJdYQrWgJZbildTEFCTAy15gi3dpA/VwKHMghTjmuw9vzkz TXf4QFapIRwycCyHmYsF/JdoGivYmrwtbGJiTzge8LLt/QuWsis4a3lMtDGy909Kv92FwJ8OTZW mEY7N7SHG88tmxNB/5Y5Q2/EBa3a5rwf1NN/a9Bfw61UArkqGeZeiyI8m1g/KceTfAC5Lcna+nV b9FLgTCQhoVvcx+O/j09lwuqtPjZ24W/5bVp/9BLLm1cak+34fGQ+1vRJ1EkXZcNiS7J7ptLvY1 WYHoFVDd60dpA+mdX7j0eg== X-Received: by 2002:a17:902:d54e:b0:235:6aa:1675 with SMTP id d9443c01a7336-23601ee0108mr4448705ad.52.1749148327884; Thu, 05 Jun 2025 11:32:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE8anFpbUiAtQTPh5i+Y3L4P6zV7H6CR2FiWWEvnWMcwq9/7jX7gsE9Cmpi8vb0MAgBmCT3fw== X-Received: by 2002:a17:902:d54e:b0:235:6aa:1675 with SMTP id d9443c01a7336-23601ee0108mr4448185ad.52.1749148327473; Thu, 05 Jun 2025 11:32:07 -0700 (PDT) Received: from localhost ([2601:1c0:5000:d5c:89fa:e299:1a34:c1f5]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23506cd75e1sm122853425ad.112.2025.06.05.11.32.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Jun 2025 11:32:07 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, Connor Abbott , Rob Clark , Abhinav Kumar , Arnd Bergmann , =?UTF-8?q?Christian=20K=C3=B6nig?= , David Airlie , Dmitry Baryshkov , Eugene Lepshy , Jessica Zhang , Jonathan Marek , Jun Nie , Konrad Dybcio , Krzysztof Kozlowski , linaro-mm-sig@lists.linaro.org (moderated list:DMA BUFFER SHARING FRAMEWORK:Keyword:\bdma_(?:buf|fence|resv)\b), linux-kernel@vger.kernel.org (open list), linux-media@vger.kernel.org (open list:DMA BUFFER SHARING FRAMEWORK:Keyword:\bdma_(?:buf|fence|resv)\b), Maarten Lankhorst , Marijn Suijten , Maxime Ripard , Rob Clark , Sean Paul , Simona Vetter , Sumit Semwal , Thomas Zimmermann Subject: [PATCH v6 00/40] drm/msm: sparse / "VM_BIND" support Date: Thu, 5 Jun 2025 11:28:45 -0700 Message-ID: <20250605183111.163594-1-robin.clark@oss.qualcomm.com> X-Mailer: git-send-email 2.49.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: 4AU9inDr_xsyoVyT875LCbdjcxIHGeGc X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjA1MDE2NSBTYWx0ZWRfX2ZU5f8VTh0ub Y/c+cG8xXuZj8+uVqA6WqKcsHa3EhnCGFQ2S01I2N6S4jt4jahnoDg14beJSbj/xJruHkyLqsxo n/OIdQ2sMBctRBarnOKOhVMWcSYThKMvTXj0tQ+U5N1K1gQJEGAOGNVGaTxHdYVHx3In7JZkSrD yLFkiU795sQ6iaI3uyN+tiXo7o1Dvu0sdwYJeIF51xAf0z7okodO0AJI5Eh9Z58d5HcdQCe7UK0 STaavd6YluFRRuW2oXmEjPlf31NBeK0KtqoMD2Cq/2JEJf7ghVYAIyqBS1WC+6uXpv3+/DxClHc J5y4gDVKYCxTKgKEAwizLqY7xIkpfS/fqgwK8MkEOzQAcr+olqv8QKBvTAhcfkONljaozn/wndI xKKu6Wm9uDC87qYoMuzuOrgUYK9YvuEj3iGGN/Y4Aghuqu2+r83SWIBQnZXDi1Amd5kDKUEX X-Authority-Analysis: v=2.4 cv=RdWQC0tv c=1 sm=1 tr=0 ts=6841e2a8 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=xqWC_Br6kY4A:10 a=6IFa9wvqVegA:10 a=e5mUnYsNAAAA:8 a=VwQbUJbxAAAA:8 a=pGLkceISAAAA:8 a=zBYVM8QCAAAA:8 a=ajksXRGWIgAGF9WJ9h0A:9 a=eVM1_HBmYRkA:10 a=YgSuLXRpIuYA:10 a=te1wHPZ5H10A:10 a=1OuFwYUASf3TG4hYMiVC:22 a=Vxmtnl_E_bksehYqCbjh:22 a=ArXkYGXkE6hBHcUMFODu:22 X-Proofpoint-GUID: 4AU9inDr_xsyoVyT875LCbdjcxIHGeGc X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-06-05_05,2025-06-05_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 mlxscore=0 priorityscore=1501 phishscore=0 clxscore=1015 lowpriorityscore=0 malwarescore=0 suspectscore=0 impostorscore=0 spamscore=0 mlxlogscore=999 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2506050165 Conversion to DRM GPU VA Manager[1], and adding support for Vulkan Sparse Memory[2] in the form of: 1. A new VM_BIND submitqueue type for executing VM MSM_SUBMIT_BO_OP_MAP/ MAP_NULL/UNMAP commands 2. A new VM_BIND ioctl to allow submitting batches of one or more MAP/MAP_NULL/UNMAP commands to a VM_BIND submitqueue I did not implement support for synchronous VM_BIND commands. Since userspace could just immediately wait for the `SUBMIT` to complete, I don't think we need this extra complexity in the kernel. Synchronous/immediate VM_BIND operations could be implemented with a 2nd VM_BIND submitqueue. The corresponding mesa MR: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32533 Changes in v6: - Drop io-pgtable-arm patch as it has already been picked up in the iommu tree. - Rework to drop gpuvm changes. To mitigate the limitation of gpuvm when it comes to lazy unmap (and to avoid ~5ms of unmap per pageflip!) a vma_ref refcount is added. This refcount is incremented when a BO is pinned for scanout, and for userspace handles and dma-bufs. The VMA is torn down when this count drops to zero, breaking the reference loop between the VM_BO and BO. But as long as a pin or userspace handle is keeping a reference to the BO live, we allow the harmless reference loop to live. (This is only for kernel managed VMs, which includes the kms VM.) If no userspace process has some sort of handle to the BO, it is unlikely to be reused again. (The exception is GET_FB, but in that case the vma_ref >= 1 due to pin for scan- out.) - Drop gpu sched changes for throttling and move this into the driver. We can re-visit a more generic solution when some other driver realizes they need the same thing. - Link to v5: https://lore.kernel.org/all/20250519175348.11924-1-robdclark@gmail.com/ Changes in v5: - Improved drm/sched enqueue_credit comments, and better define the return from drm_sched_entity_push_job() - Improve DRM_GPUVM_VA_WEAK_REF comments, and additional WARN_ON()s to make it clear that some of the gpuvm functionality is not available in this mode. - Link to v4: https://lore.kernel.org/all/20250514175527.42488-1-robdclark@gmail.com/ Changes in v4: - Various locking/etc fixes - Optimize the pgtable preallocation. If userspace sorts the VM_BIND ops then the kernel detects ops that fall into the same 2MB last level PTD to avoid duplicate page preallocation. - Add way to throttle pushing jobs to the scheduler, to cap the amount of potentially temporary prealloc'd pgtable pages. - Add vm_log to devcoredump for debugging. If the vm_log_shift module param is set, keep a log of the last 1< msm_context drm/msm: Improve msm_context comments drm/msm: Rename msm_gem_address_space -> msm_gem_vm drm/msm: Remove vram carveout support drm/msm: Collapse vma allocation and initialization drm/msm: Collapse vma close and delete drm/msm: Don't close VMAs on purge drm/msm: Stop passing vm to msm_framebuffer drm/msm: Refcount framebuffer pins drm/msm: drm_gpuvm conversion drm/msm: Convert vm locking drm/msm: Use drm_gpuvm types more drm/msm: Split out helper to get iommu prot flags drm/msm: Add mmu support for non-zero offset drm/msm: Add PRR support drm/msm: Rename msm_gem_vma_purge() -> _unmap() drm/msm: Drop queued submits on lastclose() drm/msm: Lazily create context VM drm/msm: Add opt-in for VM_BIND drm/msm: Mark VM as unusable on GPU hangs drm/msm: Add _NO_SHARE flag drm/msm: Crashdump prep for sparse mappings drm/msm: rd dumping prep for sparse mappings drm/msm: Crashdump support for sparse drm/msm: rd dumping support for sparse drm/msm: Extract out syncobj helpers drm/msm: Use DMA_RESV_USAGE_BOOKKEEP/KERNEL drm/msm: Add VM_BIND submitqueue drm/msm: Support IO_PGTABLE_QUIRK_NO_WARN_ON drm/msm: Support pgtable preallocation drm/msm: Split out map/unmap ops drm/msm: Add VM_BIND ioctl drm/msm: Add VM logging for VM_BIND updates drm/msm: Add VMA unmap reason drm/msm: Add mmu prealloc tracepoint drm/msm: use trylock for debugfs drm/msm: Bump UAPI version drm/msm: Defer VMA unmap for fb unpins drm/msm: Add VM_BIND throttling drivers/gpu/drm/drm_gem.c | 14 +- drivers/gpu/drm/msm/Kconfig | 1 + drivers/gpu/drm/msm/Makefile | 1 + drivers/gpu/drm/msm/adreno/a2xx_gpu.c | 25 +- drivers/gpu/drm/msm/adreno/a2xx_gpummu.c | 5 +- drivers/gpu/drm/msm/adreno/a3xx_gpu.c | 17 +- drivers/gpu/drm/msm/adreno/a4xx_gpu.c | 17 +- drivers/gpu/drm/msm/adreno/a5xx_debugfs.c | 4 +- drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 22 +- drivers/gpu/drm/msm/adreno/a5xx_power.c | 2 +- drivers/gpu/drm/msm/adreno/a5xx_preempt.c | 10 +- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 32 +- drivers/gpu/drm/msm/adreno/a6xx_gmu.h | 2 +- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 49 +- drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c | 6 +- drivers/gpu/drm/msm/adreno/a6xx_preempt.c | 10 +- drivers/gpu/drm/msm/adreno/adreno_device.c | 4 - drivers/gpu/drm/msm/adreno/adreno_gpu.c | 99 +- drivers/gpu/drm/msm/adreno/adreno_gpu.h | 23 +- .../drm/msm/disp/dpu1/dpu_encoder_phys_wb.c | 11 +- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 20 +- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.h | 3 +- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 18 +- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 22 +- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.h | 2 - drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c | 6 +- drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c | 28 +- drivers/gpu/drm/msm/disp/mdp4/mdp4_plane.c | 18 +- drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c | 4 +- drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 19 +- drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c | 18 +- drivers/gpu/drm/msm/dsi/dsi_host.c | 14 +- drivers/gpu/drm/msm/msm_drv.c | 184 +- drivers/gpu/drm/msm/msm_drv.h | 29 +- drivers/gpu/drm/msm/msm_fb.c | 30 +- drivers/gpu/drm/msm/msm_fbdev.c | 2 +- drivers/gpu/drm/msm/msm_gem.c | 553 +++--- drivers/gpu/drm/msm/msm_gem.h | 277 ++- drivers/gpu/drm/msm/msm_gem_prime.c | 48 + drivers/gpu/drm/msm/msm_gem_shrinker.c | 104 +- drivers/gpu/drm/msm/msm_gem_submit.c | 306 ++-- drivers/gpu/drm/msm/msm_gem_vma.c | 1486 ++++++++++++++++- drivers/gpu/drm/msm/msm_gpu.c | 211 ++- drivers/gpu/drm/msm/msm_gpu.h | 147 +- drivers/gpu/drm/msm/msm_gpu_trace.h | 14 + drivers/gpu/drm/msm/msm_iommu.c | 302 +++- drivers/gpu/drm/msm/msm_kms.c | 18 +- drivers/gpu/drm/msm/msm_kms.h | 2 +- drivers/gpu/drm/msm/msm_mmu.h | 38 +- drivers/gpu/drm/msm/msm_rd.c | 62 +- drivers/gpu/drm/msm/msm_ringbuffer.c | 10 +- drivers/gpu/drm/msm/msm_submitqueue.c | 96 +- drivers/gpu/drm/msm/msm_syncobj.c | 172 ++ drivers/gpu/drm/msm/msm_syncobj.h | 37 + include/drm/drm_gem.h | 10 +- include/uapi/drm/msm_drm.h | 149 +- 56 files changed, 3553 insertions(+), 1260 deletions(-) create mode 100644 drivers/gpu/drm/msm/msm_syncobj.c create mode 100644 drivers/gpu/drm/msm/msm_syncobj.h -- 2.49.0