Re: [PATCH v3 1/3] dt-bindings: eeprom: Add ST M24LR support

[Abd-Alrhman Masalkhi <abd.masalkhi@gmail.com>]

Hi Krzysztof,

thank you for the feedback.

> How did you implement this feedback:
>
> "That's not a misc device, but eeprom. Place it in appropriate directory."
> ?
>
> There is no such device as a misc device.

I will move it to the eeprom dirctory 

>> +  reg:
>> +    description:
>> +      Two I2C address, the primary for control registers, the secondary
>> +      for EEPROM access.
>> +    minItems: 2
>> +    maxItems: 2
>
> Replace this all with items and description:
> items:
>   - description: foo
>   - description: bar

I will do that.


>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +
>> +unevaluatedProperties: false
>> +
>> +examples:
>> +  - |
>> +    i2c {
>> +      #address-cells = <1>;
>> +      #size-cells = <0>;
>> +
>> +      eeprom@57 {
>> +        compatible = "st,m24lr04e-r";
>> +        reg = <0x57>, /* primary-device */
>> +              <0x53>; /* secondary-device */
>
> Where is the rest of at24 properties? Not relevant? Not correct? I had
> impression this is fully at24 compatible.

The driver does not currently accept at24-style configuration properties
(e.g., pagesize, address-width) because the EEPROM access is handled
internally using fixed parameters per device variant. Let me know if
adding support for these via DT is preferred, I'm happy to extend it
for flexibility.

Best regards,
Abd-Alrhman Masalkhi