From: Andrew Morton <akpm@linux-foundation.org>
To: wangfushuai <wangfushuai@baidu.com>
Cc: <david@redhat.com>, <andrii@kernel.org>, <osalvador@suse.de>,
<Liam.Howlett@Oracle.com>, <christophe.leroy@csgroup.eu>,
<linux-kernel@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH] /proc/pid/smaps: add mo info for vma in NOMMU system
Date: Sat, 7 Jun 2025 14:18:57 -0700 [thread overview]
Message-ID: <20250607141857.40b912e164b8211b6d62eafd@linux-foundation.org> (raw)
In-Reply-To: <20250607165335.87054-1-wangfushuai@baidu.com>
On Sun, 8 Jun 2025 00:53:35 +0800 wangfushuai <wangfushuai@baidu.com> wrote:
> Add mo in /proc/[pid]/smaps to indicate vma is marked VM_MAYOVERLAY,
> which means the file mapping may overlay in NOMMU system.
>
> ...
>
> Fixes: b6b7a8faf05c ("mm/nommu: don't use VM_MAYSHARE for MAP_PRIVATE mappings")
In what sense does this "fix" b6b7a8faf05c? Which, after all, said "no
functional change intended".
It does appear to be an improvement to the NOMMU user interface.
However it is non-backward-compatible - perhaps there's existing
userspace which is looking for "um" and which now needs to be changed
to look for "mo".
We could prevent this by continiing to show "um" on CONFIG_MMU and
additionally showing the new "mo". If we do this, let's have a code
comment in show_smap_vma_flags() explaining why the code is this way.
next prev parent reply other threads:[~2025-06-07 21:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-07 16:53 wangfushuai
2025-06-07 17:58 ` David Hildenbrand
2025-06-07 21:18 ` Andrew Morton [this message]
2025-06-10 11:15 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250607141857.40b912e164b8211b6d62eafd@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=Liam.Howlett@Oracle.com \
--cc=andrii@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=david@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=osalvador@suse.de \
--cc=wangfushuai@baidu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®