mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jacopo Mondi <jacopo.mondi+renesas@ideasonboard.com>
To: "Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
	"Mauro Carvalho Chehab" <mchehab@kernel.org>,
	"Kieran Bingham" <kieran.bingham+renesas@ideasonboard.com>,
	"Niklas Söderlund" <niklas.soderlund@ragnatech.se>
Cc: linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	 linux-kernel@vger.kernel.org,
	 Jacopo Mondi <jacopo.mondi+renesas@ideasonboard.com>,
	 Koji Matsuoka <koji.matsuoka.xm@renesas.com>,
	 LUU HOAI <hoai.luu.ub@renesas.com>
Subject: [PATCH 2/3] media: vsp1: Reset FCP for VSPD
Date: Mon, 09 Jun 2025 21:01:43 +0200	[thread overview]
Message-ID: <20250609-vspx-reset-v1-2-9f17277ff1e2@ideasonboard.com> (raw)
In-Reply-To: <20250609-vspx-reset-v1-0-9f17277ff1e2@ideasonboard.com>

From: Koji Matsuoka <koji.matsuoka.xm@renesas.com>

According to H/W manual v1.00, VSPD must be excecuted
FCP_RST.SOFTRST after VI6_SRESET.SRST. So this patch adds it.
VSPDL is not applicable.

Signed-off-by: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
Signed-off-by: LUU HOAI <hoai.luu.ub@renesas.com>
Signed-off-by: Jacopo Mondi <jacopo.mondi+renesas@ideasonboard.com>
---
 drivers/media/platform/renesas/vsp1/vsp1_pipe.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/media/platform/renesas/vsp1/vsp1_pipe.c b/drivers/media/platform/renesas/vsp1/vsp1_pipe.c
index 3cbb768cf6adc8cb182d8d31c5b9a9d3565785e7..a6e5e10f3ef275c1b081c3d957e6cf356332afce 100644
--- a/drivers/media/platform/renesas/vsp1/vsp1_pipe.c
+++ b/drivers/media/platform/renesas/vsp1/vsp1_pipe.c
@@ -13,6 +13,7 @@
 #include <linux/wait.h>
 
 #include <media/media-entity.h>
+#include <media/rcar-fcp.h>
 #include <media/v4l2-subdev.h>
 
 #include "vsp1.h"
@@ -22,6 +23,7 @@
 #include "vsp1_hgo.h"
 #include "vsp1_hgt.h"
 #include "vsp1_pipe.h"
+#include "vsp1_regs.h"
 #include "vsp1_rwpf.h"
 #include "vsp1_uds.h"
 
@@ -512,6 +514,11 @@ int vsp1_pipeline_stop(struct vsp1_pipeline *pipe)
 			pipe->state = VSP1_PIPELINE_STOPPED;
 			spin_unlock_irqrestore(&pipe->irqlock, flags);
 		}
+
+		if ((vsp1->version & VI6_IP_VERSION_MODEL_MASK) ==
+		    VI6_IP_VERSION_MODEL_VSPD_GEN3)
+			ret |= rcar_fcp_soft_reset(vsp1->fcp);
+
 	} else {
 		/* Otherwise just request a stop and wait. */
 		spin_lock_irqsave(&pipe->irqlock, flags);

-- 
2.49.0


  parent reply	other threads:[~2025-06-09 19:02 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-09 19:01 [PATCH 0/3] media: vsp1: Add FCP soft reset procedure Jacopo Mondi
2025-06-09 19:01 ` [PATCH 1/3] media: rcar-fcp: Add rcar_fcp_soft_reset() Jacopo Mondi
2025-06-11 23:20   ` Laurent Pinchart
2025-06-09 19:01 ` Jacopo Mondi [this message]
2025-06-11 23:29   ` [PATCH 2/3] media: vsp1: Reset FCP for VSPD Laurent Pinchart
2025-06-11 23:34     ` Laurent Pinchart
2025-06-12  9:33     ` Geert Uytterhoeven
2025-06-12  9:37       ` Laurent Pinchart
2025-06-12  9:46         ` Jacopo Mondi
2025-06-12  9:36     ` Geert Uytterhoeven
2025-06-09 19:01 ` [PATCH 3/3] media: vsp1: Reset FCP for VSPX Jacopo Mondi
2025-06-11 23:36   ` Laurent Pinchart
2025-06-12  9:48     ` Jacopo Mondi
2025-06-12 10:12       ` Laurent Pinchart
2025-06-12 10:20         ` Jacopo Mondi
2025-06-12 17:55           ` Niklas Söderlund
2025-06-12 18:05             ` Jacopo Mondi
2025-06-13 14:04               ` Niklas Söderlund
2025-06-11 14:42 ` [PATCH 0/3] media: vsp1: Add FCP soft reset procedure Niklas Söderlund

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250609-vspx-reset-v1-2-9f17277ff1e2@ideasonboard.com \
    --to=jacopo.mondi+renesas@ideasonboard.com \
    --cc=hoai.luu.ub@renesas.com \
    --cc=kieran.bingham+renesas@ideasonboard.com \
    --cc=koji.matsuoka.xm@renesas.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=niklas.soderlund@ragnatech.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®