From: Yunhui Cui <cuiyunhui@bytedance.com>
To: arnd@arndb.de, andriy.shevchenko@linux.intel.com,
benjamin.larsson@genexis.eu, cuiyunhui@bytedance.com,
gregkh@linuxfoundation.org, heikki.krogerus@linux.intel.com,
ilpo.jarvinen@linux.intel.com, jirislaby@kernel.org,
jkeeping@inmusicbrands.com, john.ogness@linutronix.de,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
markus.mayer@linaro.org, matt.porter@linaro.org,
namcao@linutronix.de, paulmck@kernel.org, pmladek@suse.com,
schnelle@linux.ibm.com, sunilvl@ventanamicro.com,
tim.kryger@linaro.org, stable@vger.kernel.org
Subject: [PATCH v8 3/4] serial: 8250_dw: assert port->lock is held in dw8250_force_idle()
Date: Mon, 9 Jun 2025 15:43:47 +0800 [thread overview]
Message-ID: <20250609074348.54899-3-cuiyunhui@bytedance.com> (raw)
In-Reply-To: <20250609074348.54899-1-cuiyunhui@bytedance.com>
Reading UART_RX and checking whether UART_LSR_DR is set should be
atomic. Ensure the caller of dw8250_force_idle() holds port->lock.
Signed-off-by: Yunhui Cui <cuiyunhui@bytedance.com>
---
drivers/tty/serial/8250/8250_dw.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c
index 1902f29444a1c..8b0018fadccea 100644
--- a/drivers/tty/serial/8250/8250_dw.c
+++ b/drivers/tty/serial/8250/8250_dw.c
@@ -13,6 +13,7 @@
#include <linux/delay.h>
#include <linux/device.h>
#include <linux/io.h>
+#include <linux/lockdep.h>
#include <linux/mod_devicetable.h>
#include <linux/module.h>
#include <linux/notifier.h>
@@ -117,6 +118,9 @@ static void dw8250_force_idle(struct uart_port *p)
struct uart_8250_port *up = up_to_u8250p(p);
unsigned int lsr;
+ /* Reading UART_LSR and UART_RX should be atomic. */
+ lockdep_assert_held_once(&p->lock);
+
/*
* The following call currently performs serial_out()
* against the FCR register. Because it differs to LCR
--
2.39.5
next prev parent reply other threads:[~2025-06-09 7:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-09 7:43 [PATCH v8 1/4] serial: 8250: fix panic due to PSLVERR Yunhui Cui
2025-06-09 7:43 ` [PATCH v8 2/4] serial: 8250: avoid potential PSLVERR issue Yunhui Cui
2025-06-09 7:43 ` Yunhui Cui [this message]
2025-06-09 7:43 ` [PATCH v8 4/4] serial: 8250_dw: fix PSLVERR on RX_TIMEOUT Yunhui Cui
2025-06-09 10:09 ` [PATCH v8 1/4] serial: 8250: fix panic due to PSLVERR Greg KH
2025-06-09 13:18 ` [External] " yunhui cui
2025-06-09 13:44 ` Greg KH
2025-06-09 20:06 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250609074348.54899-3-cuiyunhui@bytedance.com \
--to=cuiyunhui@bytedance.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=benjamin.larsson@genexis.eu \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=jkeeping@inmusicbrands.com \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=markus.mayer@linaro.org \
--cc=matt.porter@linaro.org \
--cc=namcao@linutronix.de \
--cc=paulmck@kernel.org \
--cc=pmladek@suse.com \
--cc=schnelle@linux.ibm.com \
--cc=stable@vger.kernel.org \
--cc=sunilvl@ventanamicro.com \
--cc=tim.kryger@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®