From: Chen Linxuan <chenlinxuan@uniontech.com>
To: Shuah Khan <shuah@kernel.org>,
Christian Brauner <brauner@kernel.org>,
Amir Goldstein <amir73il@gmail.com>,
John Hubbard <jhubbard@nvidia.com>,
Miklos Szeredi <mszeredi@redhat.com>, Jan Kara <jack@suse.cz>,
Chen Linxuan <chenlinxuan@uniontech.com>
Cc: zhanjun@uniontech.com, niecheng1@uniontech.com,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH RESEND] selftests: Suppress unused variable warning
Date: Tue, 10 Jun 2025 10:07:45 +0800 [thread overview]
Message-ID: <20250610020758.2798787-2-chenlinxuan@uniontech.com> (raw)
When running `make kselftest`, the following compilation warning was encountered:
mount-notify_test.c: In function ‘fanotify_rmdir’:
mount-notify_test.c:490:17: warning: ignoring return value of ‘chdir’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
490 | chdir("/");
| ^~~~~~~~~~
This patch addresses the warning by
explicitly suppressing the unused result of the `chdir` function.
Signed-off-by: Chen Linxuan <chenlinxuan@uniontech.com>
---
.../selftests/filesystems/mount-notify/mount-notify_test.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/filesystems/mount-notify/mount-notify_test.c b/tools/testing/selftests/filesystems/mount-notify/mount-notify_test.c
index 63ce708d93ed0..34afe27b7978f 100644
--- a/tools/testing/selftests/filesystems/mount-notify/mount-notify_test.c
+++ b/tools/testing/selftests/filesystems/mount-notify/mount-notify_test.c
@@ -465,7 +465,9 @@ TEST_F(fanotify, rmdir)
ASSERT_GE(ret, 0);
if (ret == 0) {
- chdir("/");
+ // Suppress -Wunused-result
+ // Ref: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66425#c34
+ (void) !chdir("/");
unshare(CLONE_NEWNS);
mount("", "/", NULL, MS_REC|MS_PRIVATE, NULL);
umount2("/a", MNT_DETACH);
--
2.43.0
next reply other threads:[~2025-06-10 2:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-10 2:07 Chen Linxuan [this message]
2025-06-18 21:23 ` Shuah Khan
2025-06-19 7:46 ` Chen Linxuan
2025-06-19 17:00 ` Shuah Khan
2025-06-19 19:00 ` John Hubbard
2025-06-19 21:40 ` Shuah Khan
2025-06-19 21:43 ` Shuah Khan
2025-06-20 2:06 ` Chen Linxuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250610020758.2798787-2-chenlinxuan@uniontech.com \
--to=chenlinxuan@uniontech.com \
--cc=amir73il@gmail.com \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=jhubbard@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mszeredi@redhat.com \
--cc=niecheng1@uniontech.com \
--cc=shuah@kernel.org \
--cc=zhanjun@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®