From: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
To: donald.hunter@gmail.com, kuba@kernel.org, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com, horms@kernel.org,
vadim.fedorenko@linux.dev, jiri@resnulli.us,
anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com,
andrew+netdev@lunn.ch, aleksandr.loktionov@intel.com,
milena.olech@intel.com, corbet@lwn.net
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
intel-wired-lan@lists.osuosl.org, linux-doc@vger.kernel.org,
Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
Subject: [PATCH net-next v5 0/3] dpll: add all inputs phase offset monitor
Date: Tue, 10 Jun 2025 07:53:35 +0200 [thread overview]
Message-ID: <20250610055338.1679463-1-arkadiusz.kubalewski@intel.com> (raw)
Add dpll device level feature: phase offset monitor.
Phase offset measurement is typically performed against the current active
source. However, some DPLL (Digital Phase-Locked Loop) devices may offer
the capability to monitor phase offsets across all available inputs.
The attribute and current feature state shall be included in the response
message of the ``DPLL_CMD_DEVICE_GET`` command for supported DPLL devices.
In such cases, users can also control the feature using the
``DPLL_CMD_DEVICE_SET`` command by setting the ``enum dpll_feature_state``
values for the attribute.
Once enabled the phase offset measurements for the input shall be returned
in the ``DPLL_A_PIN_PHASE_OFFSET`` attribute.
Implement feature support in ice driver for dpll-enabled devices.
Verify capability:
$ ./tools/net/ynl/pyynl/cli.py \
--spec Documentation/netlink/specs/dpll.yaml \
--dump device-get
[{'clock-id': 4658613174691613800,
'id': 0,
'lock-status': 'locked-ho-acq',
'mode': 'automatic',
'mode-supported': ['automatic'],
'module-name': 'ice',
'type': 'eec'},
{'clock-id': 4658613174691613800,
'id': 1,
'lock-status': 'locked-ho-acq',
'mode': 'automatic',
'mode-supported': ['automatic'],
'module-name': 'ice',
'phase-offset-monitor': 'disable',
'type': 'pps'}]
Enable the feature:
$ ./tools/net/ynl/pyynl/cli.py \
--spec Documentation/netlink/specs/dpll.yaml \
--do device-set --json '{"id":1, "phase-offset-monitor":"enable"}'
Verify feature is enabled:
$ ./tools/net/ynl/pyynl/cli.py \
--spec Documentation/netlink/specs/dpll.yaml \
--dump device-get
[
[...]
{'capabilities': {'all-inputs-phase-offset-monitor'},
'clock-id': 4658613174691613800,
'id': 1,
[...]
'phase-offset-monitor': 'enable',
[...]]
Arkadiusz Kubalewski (3):
dpll: add phase-offset-monitor feature to netlink spec
dpll: add phase_offset_monitor_get/set callback ops
ice: add phase offset monitor for all PPS dpll inputs
Documentation/driver-api/dpll.rst | 18 ++
Documentation/netlink/specs/dpll.yaml | 24 +++
drivers/dpll/dpll_netlink.c | 69 ++++++-
drivers/dpll/dpll_nl.c | 5 +-
.../net/ethernet/intel/ice/ice_adminq_cmd.h | 20 ++
drivers/net/ethernet/intel/ice/ice_common.c | 26 +++
drivers/net/ethernet/intel/ice/ice_common.h | 3 +
drivers/net/ethernet/intel/ice/ice_dpll.c | 194 +++++++++++++++++-
drivers/net/ethernet/intel/ice/ice_dpll.h | 8 +
drivers/net/ethernet/intel/ice/ice_main.c | 4 +
include/linux/dpll.h | 8 +
include/uapi/linux/dpll.h | 12 ++
12 files changed, 385 insertions(+), 6 deletions(-)
base-commit: 2c7e4a2663a1ab5a740c59c31991579b6b865a26
--
2.38.1
next reply other threads:[~2025-06-10 5:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-10 5:53 Arkadiusz Kubalewski [this message]
2025-06-10 5:53 ` [PATCH net-next v5 1/3] dpll: add phase-offset-monitor feature to netlink spec Arkadiusz Kubalewski
2025-06-10 5:53 ` [PATCH net-next v5 2/3] dpll: add phase_offset_monitor_get/set callback ops Arkadiusz Kubalewski
2025-06-10 5:53 ` [PATCH net-next v5 3/3] ice: add phase offset monitor for all PPS dpll inputs Arkadiusz Kubalewski
2025-06-11 23:55 ` [PATCH net-next v5 0/3] dpll: add all inputs phase offset monitor Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250610055338.1679463-1-arkadiusz.kubalewski@intel.com \
--to=arkadiusz.kubalewski@intel.com \
--cc=aleksandr.loktionov@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=milena.olech@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®