From: Steven Rostedt <rostedt@goodmis.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
linux-kernel@vger.kernel.org, Ben Segall <bsegall@google.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Ingo Molnar <mingo@redhat.com>,
Juri Lelli <juri.lelli@redhat.com>, Mel Gorman <mgorman@suse.de>,
Thomas Gleinxer <tglx@linutronix.de>,
Valentin Schneider <vschneid@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>
Subject: Re: [PATCH v2] sched: Remove a preempt-disable section in rt_mutex_setprio()
Date: Wed, 11 Jun 2025 10:14:57 -0400 [thread overview]
Message-ID: <20250611101457.13ea44f5@batman.local.home> (raw)
In-Reply-To: <20250611090306.GA2273038@noisy.programming.kicks-ass.net>
On Wed, 11 Jun 2025 11:03:06 +0200
Peter Zijlstra <peterz@infradead.org> wrote:
> > --- a/kernel/sched/core.c
> > +++ b/kernel/sched/core.c
> > @@ -7292,14 +7292,10 @@ void rt_mutex_setprio(struct task_struct *p, struct task_struct *pi_task)
> >
> > check_class_changed(rq, p, prev_class, oldprio);
> > out_unlock:
> > - /* Avoid rq from going away on us: */
> > - preempt_disable();
>
> Perhaps add:
>
> /* IRQs are still disabled */
>
> or something to that effect such that it is obvious from reading the
> code that dropping the lock will not enable preemption?
Hmm, wouldn't lockdep_assert_irqs_disabled() be better than a comment.
It lets people know that interrupts are disabled and when lockdep is
enabled it also makes sure they are.
-- Steve
prev parent reply other threads:[~2025-06-11 14:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-10 14:47 Sebastian Andrzej Siewior
2025-06-11 9:03 ` Peter Zijlstra
2025-06-11 9:54 ` [PATCH v3] " Sebastian Andrzej Siewior
2025-06-11 14:14 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250611101457.13ea44f5@batman.local.home \
--to=rostedt@goodmis.org \
--cc=bigeasy@linutronix.de \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®