From: "Jiri Slaby (SUSE)" <jirislaby@kernel.org>
To: linux-kernel@vger.kernel.org
Cc: tglx@linutronix.de, Arnd Bergmann <arnd@arndb.de>,
Mario Limonciello <mario.limonciello@amd.com>,
Nathan Chancellor <nathan@kernel.org>,
"Jiri Slaby (SUSE)" <jirislaby@kernel.org>
Subject: [PATCH] mfd: fix building without CONFIG_OF
Date: Wed, 11 Jun 2025 12:43:29 +0200 [thread overview]
Message-ID: <20250611104348.192092-1-jirislaby@kernel.org> (raw)
From: Arnd Bergmann <arnd@arndb.de>
Using the of_fwnode_handle() means that local 'node' variables are unused
whenever CONFIG_OF is disabled for compile testing:
drivers/mfd/88pm860x-core.c: In function 'device_irq_init':
drivers/mfd/88pm860x-core.c:576:29: error: unused variable 'node' [-Werror=unused-variable]
576 | struct device_node *node = i2c->dev.of_node;
| ^~~~
drivers/mfd/max8925-core.c: In function 'max8925_irq_init':
drivers/mfd/max8925-core.c:659:29: error: unused variable 'node' [-Werror=unused-variable]
659 | struct device_node *node = chip->dev->of_node;
| ^~~~
drivers/mfd/twl4030-irq.c: In function 'twl4030_init_irq':
drivers/mfd/twl4030-irq.c:679:46: error: unused variable 'node' [-Werror=unused-variable]
679 | struct device_node *node = dev->of_node;
| ^~~~
Replace these with the corresponding dev_fwnode() lookups that
keep the code simpler in addition to avoiding the warnings.
Fixes: e3d44f11da04 ("mfd: Switch to irq_domain_create_*()")
Cc: Mario Limonciello <mario.limonciello@amd.com>
Cc: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
---
drivers/mfd/88pm860x-core.c | 3 +--
drivers/mfd/max8925-core.c | 6 +++---
drivers/mfd/twl4030-irq.c | 3 +--
3 files changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/mfd/88pm860x-core.c b/drivers/mfd/88pm860x-core.c
index 488e346047c1..77230fbe07be 100644
--- a/drivers/mfd/88pm860x-core.c
+++ b/drivers/mfd/88pm860x-core.c
@@ -573,7 +573,6 @@ static int device_irq_init(struct pm860x_chip *chip,
unsigned long flags = IRQF_TRIGGER_FALLING | IRQF_ONESHOT;
int data, mask, ret = -EINVAL;
int nr_irqs, irq_base = -1;
- struct device_node *node = i2c->dev.of_node;
mask = PM8607_B0_MISC1_INV_INT | PM8607_B0_MISC1_INT_CLEAR
| PM8607_B0_MISC1_INT_MASK;
@@ -624,7 +623,7 @@ static int device_irq_init(struct pm860x_chip *chip,
ret = -EBUSY;
goto out;
}
- irq_domain_create_legacy(of_fwnode_handle(node), nr_irqs, chip->irq_base, 0,
+ irq_domain_create_legacy(dev_fwnode(&i2c->dev), nr_irqs, chip->irq_base, 0,
&pm860x_irq_domain_ops, chip);
chip->core_irq = i2c->irq;
if (!chip->core_irq)
diff --git a/drivers/mfd/max8925-core.c b/drivers/mfd/max8925-core.c
index 78b16c67a5fc..25377dcce60e 100644
--- a/drivers/mfd/max8925-core.c
+++ b/drivers/mfd/max8925-core.c
@@ -656,7 +656,6 @@ static int max8925_irq_init(struct max8925_chip *chip, int irq,
{
unsigned long flags = IRQF_TRIGGER_FALLING | IRQF_ONESHOT;
int ret;
- struct device_node *node = chip->dev->of_node;
/* clear all interrupts */
max8925_reg_read(chip->i2c, MAX8925_CHG_IRQ1);
@@ -682,8 +681,9 @@ static int max8925_irq_init(struct max8925_chip *chip, int irq,
return -EBUSY;
}
- irq_domain_create_legacy(of_fwnode_handle(node), MAX8925_NR_IRQS, chip->irq_base, 0,
- &max8925_irq_domain_ops, chip);
+ irq_domain_create_legacy(dev_fwnode(chip->dev), MAX8925_NR_IRQS,
+ chip->irq_base, 0, &max8925_irq_domain_ops,
+ chip);
/* request irq handler for pmic main irq*/
chip->core_irq = irq;
diff --git a/drivers/mfd/twl4030-irq.c b/drivers/mfd/twl4030-irq.c
index 232c2bfe8c18..d3ab40651307 100644
--- a/drivers/mfd/twl4030-irq.c
+++ b/drivers/mfd/twl4030-irq.c
@@ -676,7 +676,6 @@ int twl4030_init_irq(struct device *dev, int irq_num)
static struct irq_chip twl4030_irq_chip;
int status, i;
int irq_base, irq_end, nr_irqs;
- struct device_node *node = dev->of_node;
/*
* TWL core and pwr interrupts must be contiguous because
@@ -691,7 +690,7 @@ int twl4030_init_irq(struct device *dev, int irq_num)
return irq_base;
}
- irq_domain_create_legacy(of_fwnode_handle(node), nr_irqs, irq_base, 0,
+ irq_domain_create_legacy(dev_fwnode(dev), nr_irqs, irq_base, 0,
&irq_domain_simple_ops, NULL);
irq_end = irq_base + TWL4030_CORE_NR_IRQS;
--
2.49.0
next reply other threads:[~2025-06-11 10:43 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-11 10:43 Jiri Slaby (SUSE) [this message]
2025-06-11 10:43 ` [PATCH] pci: altera: remove unused 'node' variable Jiri Slaby (SUSE)
2025-06-13 15:41 ` Bjorn Helgaas
2025-06-11 10:43 ` [PATCH] bus: moxtet: Use dev_fwnode() Jiri Slaby (SUSE)
2025-06-17 8:00 ` Marek Behún
2025-06-11 10:43 ` [PATCH] drm/msm: use dev_fwnode() Jiri Slaby (SUSE)
2025-06-11 10:43 ` [PATCH] edac: Use dev_fwnode() Jiri Slaby (SUSE)
2025-06-11 10:43 ` [PATCH] gpio: " Jiri Slaby (SUSE)
2025-06-11 15:18 ` Andy Shevchenko
2025-06-16 7:42 ` Bartosz Golaszewski
2025-06-11 10:43 ` [PATCH] gpu: ipu-v3: " Jiri Slaby (SUSE)
2025-06-11 10:43 ` [PATCH] i2c: " Jiri Slaby (SUSE)
2025-06-27 10:54 ` Wolfram Sang
2025-06-11 10:43 ` [PATCH] iio: " Jiri Slaby (SUSE)
2025-06-11 13:57 ` David Lechner
2025-06-12 8:46 ` [PATCH v2] iio: adc: stm32-adc: " Jiri Slaby (SUSE)
2025-06-13 17:00 ` David Lechner
2025-06-14 11:08 ` Jonathan Cameron
2025-06-11 10:43 ` [PATCH] irqchip: " Jiri Slaby (SUSE)
2025-06-11 13:51 ` [Linux-stm32] " Antonio Borneo
2025-06-12 13:13 ` [tip: irq/drivers] " tip-bot2 for Jiri Slaby (SUSE)
2025-06-17 13:04 ` [PATCH] " Nishanth Menon
2025-06-11 10:43 ` [PATCH] mailbox: " Jiri Slaby (SUSE)
2025-06-11 10:43 ` [PATCH] memory: " Jiri Slaby (SUSE)
2025-06-12 11:34 ` Krzysztof Kozlowski
2025-06-12 11:38 ` Krzysztof Kozlowski
2025-06-12 11:39 ` Krzysztof Kozlowski
2025-06-11 10:43 ` [PATCH] mfd: " Jiri Slaby (SUSE)
2025-06-12 8:48 ` Charles Keepax
2025-06-19 11:34 ` (subset) " Lee Jones
2025-06-11 10:43 ` [PATCH] misc: " Jiri Slaby (SUSE)
2025-06-11 10:43 ` [PATCH] net: " Jiri Slaby (SUSE)
2025-06-13 2:00 ` patchwork-bot+netdevbpf
2025-06-11 10:43 ` [PATCH] pci/controller: " Jiri Slaby (SUSE)
2025-06-13 16:09 ` (subset) " Manivannan Sadhasivam
2025-07-15 18:49 ` Bjorn Helgaas
2025-07-16 7:59 ` Nam Cao
2025-07-16 14:49 ` Bjorn Helgaas
2025-07-21 17:08 ` Bjorn Helgaas
2025-07-22 6:24 ` Jiri Slaby
2025-07-22 23:20 ` Bjorn Helgaas
2025-07-23 6:47 ` Jiri Slaby
2025-06-11 10:43 ` [PATCH] pinctrl: " Jiri Slaby (SUSE)
2025-06-11 11:04 ` Chen-Yu Tsai
2025-06-18 11:32 ` Linus Walleij
2025-06-11 10:43 ` [PATCH] powerpc: " Jiri Slaby (SUSE)
2025-06-11 10:43 ` [PATCH] soc: " Jiri Slaby (SUSE)
2025-06-11 15:13 ` Thierry Reding
2025-06-12 11:31 ` Krzysztof Kozlowski
2025-06-12 12:28 ` Christophe Leroy
2025-07-08 8:33 ` Christophe Leroy
2025-07-30 13:37 ` Christophe Leroy
2025-06-11 10:43 ` [PATCH] thermal: " Jiri Slaby (SUSE)
2025-06-11 15:13 ` Thierry Reding
2025-07-15 13:33 ` Daniel Lezcano
-- strict thread matches above, loose matches on Subject: below --
2025-05-20 15:40 [PATCH] mfd: fix building without CONFIG_OF Arnd Bergmann
2025-05-22 5:57 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250611104348.192092-1-jirislaby@kernel.org \
--to=jirislaby@kernel.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=nathan@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome