From: Jonathan Cameron <jic23@kernel.org>
To: David Lechner <dlechner@baylibre.com>
Cc: "Michael Hennerich" <Michael.Hennerich@analog.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: adc: ad7173: check return value of spi_setup()
Date: Wed, 11 Jun 2025 17:55:59 +0100 [thread overview]
Message-ID: <20250611175559.76fb1365@jic23-huawei> (raw)
In-Reply-To: <20250611-iio-adc-ad7173-check-spi_setup-return-v1-1-4d6f9ef0a2e4@baylibre.com>
On Wed, 11 Jun 2025 09:40:16 -0500
David Lechner <dlechner@baylibre.com> wrote:
> Check the return value of spi_setup() and propagate the error in the
> ad7173_probe() function. This is unlikely to happen since virtually
> every SPI controller supports SPI_MODE_3, but still always a good idea
> to check the return value.
>
> Signed-off-by: David Lechner <dlechner@baylibre.com>
Applied.
> ---
> drivers/iio/adc/ad7173.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/ad7173.c b/drivers/iio/adc/ad7173.c
> index 69de5886474ce2f700bf277ce707b15637113564..911001be368302fb9d7d6e8da3783751fe0f61c5 100644
> --- a/drivers/iio/adc/ad7173.c
> +++ b/drivers/iio/adc/ad7173.c
> @@ -1775,7 +1775,9 @@ static int ad7173_probe(struct spi_device *spi)
> indio_dev->info = &ad7173_info;
>
> spi->mode = SPI_MODE_3;
> - spi_setup(spi);
> + ret = spi_setup(spi);
> + if (ret)
> + return ret;
>
> ret = ad_sd_init(&st->sd, indio_dev, spi, st->info->sd_info);
> if (ret)
>
> ---
> base-commit: aff301f37e220970c2f301b5c65a8bfedf52058e
> change-id: 20250611-iio-adc-ad7173-check-spi_setup-return-072017235f3c
>
> Best regards,
prev parent reply other threads:[~2025-06-11 16:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-11 14:40 David Lechner
2025-06-11 16:55 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250611175559.76fb1365@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®