From: Daniel Lee <chullee@google.com>
To: Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <chao@kernel.org>
Cc: linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, Daniel Lee <chullee@google.com>
Subject: [PATCH 2/2] f2fs: use ioprio hint for hot and pinned files
Date: Wed, 11 Jun 2025 16:37:06 -0700 [thread overview]
Message-ID: <20250611233706.572784-3-chullee@google.com> (raw)
In-Reply-To: <20250611233706.572784-1-chullee@google.com>
Apply the `ioprio_hint` to set `F2FS_IOPRIO_WRITE` priority
on files identified as "hot" at creation and on files that are
pinned via ioctl.
Signed-off-by: Daniel Lee <chullee@google.com>
---
fs/f2fs/f2fs.h | 21 +++++++++++++++++++++
fs/f2fs/file.c | 3 +++
fs/f2fs/namei.c | 11 +++++++----
3 files changed, 31 insertions(+), 4 deletions(-)
diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
index 162d79a3c1a5..0b05b3b6386b 100644
--- a/fs/f2fs/f2fs.h
+++ b/fs/f2fs/f2fs.h
@@ -3441,6 +3441,27 @@ static inline void set_file(struct inode *inode, int type)
f2fs_mark_inode_dirty_sync(inode, true);
}
+static inline int get_ioprio(struct inode *inode)
+{
+ return F2FS_I(inode)->ioprio_hint;
+}
+
+static inline void set_ioprio(struct inode *inode, int level)
+{
+ if (get_ioprio(inode) == level)
+ return;
+ F2FS_I(inode)->ioprio_hint = level;
+ f2fs_mark_inode_dirty_sync(inode, true);
+}
+
+static inline void clear_ioprio(struct inode *inode)
+{
+ if (get_ioprio(inode) == 0)
+ return;
+ F2FS_I(inode)->ioprio_hint = 0;
+ f2fs_mark_inode_dirty_sync(inode, true);
+}
+
static inline void clear_file(struct inode *inode, int type)
{
if (!is_file(inode, type))
diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index 4fd45e94661a..95a3b4b59dd1 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -3496,6 +3496,7 @@ static int f2fs_ioc_set_pin_file(struct file *filp, unsigned long arg)
if (!pin) {
clear_inode_flag(inode, FI_PIN_FILE);
+ clear_ioprio(inode);
f2fs_i_gc_failures_write(inode, 0);
goto done;
} else if (f2fs_is_pinned_file(inode)) {
@@ -3529,6 +3530,8 @@ static int f2fs_ioc_set_pin_file(struct file *filp, unsigned long arg)
}
set_inode_flag(inode, FI_PIN_FILE);
+ file_set_hot(inode);
+ set_ioprio(inode, F2FS_IOPRIO_WRITE);
ret = F2FS_I(inode)->i_gc_failures;
done:
f2fs_update_time(sbi, REQ_TIME);
diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c
index 07e333ee21b7..0f96a0b86c40 100644
--- a/fs/f2fs/namei.c
+++ b/fs/f2fs/namei.c
@@ -191,9 +191,10 @@ static void set_compress_new_inode(struct f2fs_sb_info *sbi, struct inode *dir,
}
/*
- * Set file's temperature for hot/cold data separation
+ * Set file's temperature (for hot/cold data separation) and
+ * I/O priority, based on filename extension
*/
-static void set_file_temperature(struct f2fs_sb_info *sbi, struct inode *inode,
+static void set_file_temp_prio(struct f2fs_sb_info *sbi, struct inode *inode,
const unsigned char *name)
{
__u8 (*extlist)[F2FS_EXTENSION_LEN] = sbi->raw_super->extension_list;
@@ -212,8 +213,10 @@ static void set_file_temperature(struct f2fs_sb_info *sbi, struct inode *inode,
if (i < cold_count)
file_set_cold(inode);
- else
+ else {
file_set_hot(inode);
+ set_ioprio(inode, F2FS_IOPRIO_WRITE);
+ }
}
static struct inode *f2fs_new_inode(struct mnt_idmap *idmap,
@@ -317,7 +320,7 @@ static struct inode *f2fs_new_inode(struct mnt_idmap *idmap,
set_inode_flag(inode, FI_INLINE_DATA);
if (name && !test_opt(sbi, DISABLE_EXT_IDENTIFY))
- set_file_temperature(sbi, inode, name);
+ set_file_temp_prio(sbi, inode, name);
stat_inc_inline_xattr(inode);
stat_inc_inline_inode(inode);
--
2.50.0.rc1.591.g9c95f17f64-goog
next prev parent reply other threads:[~2025-06-11 23:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-11 23:37 [PATCH 0/2] f2fs: Fix DIO flags and add ioprio hint Daniel Lee
2025-06-11 23:37 ` [PATCH 1/2] f2fs: Apply bio flags to direct I/O Daniel Lee
2025-06-13 0:41 ` Chao Yu
2025-06-11 23:37 ` Daniel Lee [this message]
2025-06-13 0:47 ` [PATCH 2/2] f2fs: use ioprio hint for hot and pinned files Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250611233706.572784-3-chullee@google.com \
--to=chullee@google.com \
--cc=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®