From: avinashlalotra <abinashlalotra@gmail.com>
To: linux-omap@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, aaro.koskinen@iki.fi,
andreas@kemnade.info, khilman@baylibre.com, rogerq@kernel.org,
tony@atomide.com, lee@kernel.org,
avinashlalotra <abinashsinghlalotra@gmail.com>
Subject: [RFC PATCH] mfd: twl4030-irq: remove redundant 'node' variable
Date: Fri, 13 Jun 2025 17:52:51 +0530 [thread overview]
Message-ID: <20250613122251.1033078-1-abinashsinghlalotra@gmail.com> (raw)
The local variable 'node' was used only once to retrieve dev->of_node
in a call to irq_domain_create_legacy(). This patch inlines the usage
and removes the redundant variable, improving code clarity.
No functional change intended.
Signed-off-by: avinashlalotra <abinashsinghlalotra@gmail.com>
---
drivers/mfd/twl4030-irq.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/mfd/twl4030-irq.c b/drivers/mfd/twl4030-irq.c
index 232c2bfe8c18..a2ab5deef9e2 100644
--- a/drivers/mfd/twl4030-irq.c
+++ b/drivers/mfd/twl4030-irq.c
@@ -676,7 +676,6 @@ int twl4030_init_irq(struct device *dev, int irq_num)
static struct irq_chip twl4030_irq_chip;
int status, i;
int irq_base, irq_end, nr_irqs;
- struct device_node *node = dev->of_node;
/*
* TWL core and pwr interrupts must be contiguous because
@@ -691,7 +690,7 @@ int twl4030_init_irq(struct device *dev, int irq_num)
return irq_base;
}
- irq_domain_create_legacy(of_fwnode_handle(node), nr_irqs, irq_base, 0,
+ irq_domain_create_legacy(of_fwnode_handle(dev->of_node), nr_irqs, irq_base, 0,
&irq_domain_simple_ops, NULL);
irq_end = irq_base + TWL4030_CORE_NR_IRQS;
--
2.43.0
next reply other threads:[~2025-06-13 12:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-13 12:22 avinashlalotra [this message]
2025-06-19 11:39 ` (subset) " Lee Jones
2025-06-19 11:42 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250613122251.1033078-1-abinashsinghlalotra@gmail.com \
--to=abinashlalotra@gmail.com \
--cc=aaro.koskinen@iki.fi \
--cc=abinashsinghlalotra@gmail.com \
--cc=andreas@kemnade.info \
--cc=khilman@baylibre.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=rogerq@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®