From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx3.wp.pl (mx3.wp.pl [212.77.101.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6094C20F09B for ; Fri, 13 Jun 2025 16:38:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.77.101.9 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749832722; cv=none; b=V7ee2ttgrC+d7cVFUa/I9JoXeAToIy0aDJIUliyPV2E3SI4lLvSRMBXdFesP2iGCcPWz5ONsw9aSPYKPcTFd5qg9xdDz9hZpGSyFdSAJvRttI8aI1g00wCIUC82R1jI34Q/3cC49TXaKRSlimwHOLB+YR58l2KIXlQMeHD8tBKQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749832722; c=relaxed/simple; bh=roc1nCKlU6+zFLiSIX/Jhl/yRTEwG8T8BaH8kRNG7Js=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PIGnneJ2fAUBbBN+/G57eP4oAO/sT5j4paD3fyVfLIkAK7vNeU63Dh0GqJkUpwZoV+8jkL4T+IU/ZJvkZ3mbSWfYrjglOb74UMvXTRYPDYKblQXp8c4m0blqi6oV95rPFI39/CZXsm/GYVuB8PZBrR3nqVArXZwkKg2i//O13qo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=wp.pl; spf=pass smtp.mailfrom=wp.pl; dkim=pass (2048-bit key) header.d=wp.pl header.i=@wp.pl header.b=RjF8sb8C; arc=none smtp.client-ip=212.77.101.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=wp.pl Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=wp.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=wp.pl header.i=@wp.pl header.b="RjF8sb8C" Received: (wp-smtpd smtp.wp.pl 25465 invoked from network); 13 Jun 2025 18:11:52 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wp.pl; s=20241105; t=1749831112; bh=pQ8jSxcfR6n8gUoPxMTzQFYregg2HENhHGC+FgDSA2o=; h=From:To:Cc:Subject; b=RjF8sb8CrbdHhCC6jDD9N7HMHFV5isWVNKCOTeUPxLqKKbrDDvuy2lywNs3KZueX5 AngMFD65LIXZU2CDnQqMj+/CofqapTbbJsAj/vwSEIzqSpB/t4wxzXpA3WUNDiNI24 pqrW0a8f7ltcbJtx+e+IhOR94DASfoedAiNQR0kLLHuPcKxkc2lhElzAf4aQ/0E4Fu 6zQ7hhPFsWWNOpCAveQjXSj4jUWac/G6CvtF1hlQ52/ukeQkNIlmK/x+E8G1CTB4p3 EraebbWEmF4TYdfnsfOfFpAv4Iu7kyGrO++t7RTqogDZAlnZoRe+DBDcz3fuF2QxtA U0NVtm2hM8z6A== Received: from 89-64-3-149.dynamic.play.pl (HELO localhost) (stf_xl@wp.pl@[89.64.3.149]) (envelope-sender ) by smtp.wp.pl (WP-SMTPD) with ECDHE-RSA-AES256-GCM-SHA384 encrypted SMTP for ; 13 Jun 2025 18:11:52 +0200 Date: Fri, 13 Jun 2025 18:11:51 +0200 From: Stanislaw Gruszka To: Yuesong Li Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, opensource.kernel@vivo.com Subject: Re: [PATCH v1] wifi: iwlegacy: convert to use secs_to_jiffies() Message-ID: <20250613161151.GA205720@wp.pl> References: <20250612021446.3465972-1-liyuesong@vivo.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250612021446.3465972-1-liyuesong@vivo.com> X-WP-MailID: d62c7ddc87a6b367d150880345504c38 X-WP-AV: skaner antywirusowy Poczty Wirtualnej Polski X-WP-SPAM: NO 0000000 [keMB] On Thu, Jun 12, 2025 at 10:14:44AM +0800, Yuesong Li wrote: > Since secs_to_jiffies()(commit:b35108a51cf7) has been introduced, we can > use it to avoid scaling the time to msec. > > Signed-off-by: Yuesong Li Acked-by: Stanislaw Gruszka > --- > drivers/net/wireless/intel/iwlegacy/4965-mac.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/intel/iwlegacy/4965-mac.c b/drivers/net/wireless/intel/iwlegacy/4965-mac.c > index 8e58e97a148f..24a39a968db0 100644 > --- a/drivers/net/wireless/intel/iwlegacy/4965-mac.c > +++ b/drivers/net/wireless/intel/iwlegacy/4965-mac.c > @@ -1382,7 +1382,7 @@ il4965_hdl_stats(struct il_priv *il, struct il_rx_buf *rxb) > * we get a thermal update even if the uCode doesn't give us one > */ > mod_timer(&il->stats_periodic, > - jiffies + msecs_to_jiffies(recalib_seconds * 1000)); > + jiffies + secs_to_jiffies(recalib_seconds)); > > if (unlikely(!test_bit(S_SCANNING, &il->status)) && > (pkt->hdr.cmd == N_STATS)) { > -- > 2.34.1 >