Re: [PATCH 3/3] media: rcar-vin: Generate FRAME_SYNC events

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Niklas,

Thank you for the patch.

On Sat, Jun 14, 2025 at 04:15:45PM +0200, Niklas Söderlund wrote:
> Enable the VSYNC Rising Edge Detection interrupt and generate a
> FRAME_SYNC event form it. The interrupt is available on all supported
> models of the VIN (Gen2, Gen3 and Gen4).
> 
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

> ---
>  .../media/platform/renesas/rcar-vin/rcar-dma.c  | 17 +++++++++++++++++
>  .../media/platform/renesas/rcar-vin/rcar-v4l2.c |  2 ++
>  2 files changed, 19 insertions(+)
> 
> diff --git a/drivers/media/platform/renesas/rcar-vin/rcar-dma.c b/drivers/media/platform/renesas/rcar-vin/rcar-dma.c
> index 85e44a00e0fc..a1ae9c9bccc7 100644
> --- a/drivers/media/platform/renesas/rcar-vin/rcar-dma.c
> +++ b/drivers/media/platform/renesas/rcar-vin/rcar-dma.c
> @@ -14,6 +14,7 @@
>  #include <linux/interrupt.h>
>  #include <linux/pm_runtime.h>
>  
> +#include <media/v4l2-event.h>
>  #include <media/videobuf2-dma-contig.h>
>  
>  #include "rcar-vin.h"
> @@ -115,10 +116,14 @@
>  #define VNFC_S_FRAME		(1 << 0)
>  
>  /* Video n Interrupt Enable Register bits */
> +#define VNIE_VFE		BIT(17)
> +#define VNIE_VRE		BIT(16)
>  #define VNIE_FIE		BIT(4)
>  #define VNIE_EFE		BIT(1)
>  
>  /* Video n Interrupt Status Register bits */
> +#define VNINTS_VFS		BIT(17)
> +#define VNINTS_VRS		BIT(16)
>  #define VNINTS_FIS		BIT(4)
>  #define VNINTS_EFS		BIT(1)
>  
> @@ -898,6 +903,8 @@ static int rvin_setup(struct rvin_dev *vin)
>  
>  	/* Progressive or interlaced mode */
>  	interrupts = progressive ? VNIE_FIE : VNIE_EFE;
> +	/* Enable VSYNC Rising Edge Detection. */
> +	interrupts |= VNIE_VRE;
>  
>  	/* Ack interrupts */
>  	rvin_write(vin, interrupts, VNINTS_REG);
> @@ -1049,6 +1056,16 @@ static irqreturn_t rvin_irq(int irq, void *data)
>  	rvin_write(vin, status, VNINTS_REG);
>  	handled = 1;
>  
> +	/* Signal Start of Frame. */
> +	if (status & VNINTS_VRS) {
> +		struct v4l2_event event = {
> +			.type = V4L2_EVENT_FRAME_SYNC,
> +			.u.frame_sync.frame_sequence = vin->sequence,
> +		};
> +
> +		v4l2_event_queue(&vin->vdev, &event);
> +	}
> +
>  	/* Nothing to do if nothing was captured. */
>  	capture = vin->format.field == V4L2_FIELD_NONE ||
>  		vin->format.field == V4L2_FIELD_ALTERNATE ?
> diff --git a/drivers/media/platform/renesas/rcar-vin/rcar-v4l2.c b/drivers/media/platform/renesas/rcar-vin/rcar-v4l2.c
> index db091af57c19..6339de54b02b 100644
> --- a/drivers/media/platform/renesas/rcar-vin/rcar-v4l2.c
> +++ b/drivers/media/platform/renesas/rcar-vin/rcar-v4l2.c
> @@ -734,6 +734,8 @@ static int rvin_subscribe_event(struct v4l2_fh *fh,
>  				const struct v4l2_event_subscription *sub)
>  {
>  	switch (sub->type) {
> +	case V4L2_EVENT_FRAME_SYNC:
> +		return v4l2_event_subscribe(fh, sub, 2, NULL);
>  	case V4L2_EVENT_SOURCE_CHANGE:
>  		return v4l2_event_subscribe(fh, sub, 4, NULL);
>  	}

-- 
Regards,

Laurent Pinchart