mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Jeffery <andrew@codeconstruct.com.au>
To: linux-aspeed@lists.ozlabs.org
Cc: Joel Stanley <joel@jms.id.au>,
	Henry Martin <bsdhenrymartin@gmail.com>,
	 Jean Delvare <jdelvare@suse.de>,
	 Patrick Rudolph <patrick.rudolph@9elements.com>,
	 Andrew Geissler <geissonator@yahoo.com>,
	 Ninad Palsule <ninad@linux.ibm.com>,
	Patrick Venture <venture@google.com>,
	 Robert Lippert <roblip@gmail.com>,
	linux-arm-kernel@lists.infradead.org,
	 linux-kernel@vger.kernel.org,
	Andrew Jeffery <andrew@codeconstruct.com.au>
Subject: [PATCH v2 07/10] soc: aspeed: lpc-snoop: Switch to devm_clk_get_enabled()
Date: Mon, 16 Jun 2025 22:43:44 +0930	[thread overview]
Message-ID: <20250616-aspeed-lpc-snoop-fixes-v2-7-3cdd59c934d3@codeconstruct.com.au> (raw)
In-Reply-To: <20250616-aspeed-lpc-snoop-fixes-v2-0-3cdd59c934d3@codeconstruct.com.au>

Simplify clock handling as done in other drivers.

Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>
---
 drivers/soc/aspeed/aspeed-lpc-snoop.c | 20 ++++----------------
 1 file changed, 4 insertions(+), 16 deletions(-)

diff --git a/drivers/soc/aspeed/aspeed-lpc-snoop.c b/drivers/soc/aspeed/aspeed-lpc-snoop.c
index 9992212c789d4224edcc0ee1a3bb9c73f9fc661b..bd4afa7f258eb3c1e64fe87d2b4be5f8422fbaf7 100644
--- a/drivers/soc/aspeed/aspeed-lpc-snoop.c
+++ b/drivers/soc/aspeed/aspeed-lpc-snoop.c
@@ -329,26 +329,21 @@ static int aspeed_lpc_snoop_probe(struct platform_device *pdev)
 		return -ENODEV;
 	}
 
-	lpc_snoop->clk = devm_clk_get(dev, NULL);
+	lpc_snoop->clk = devm_clk_get_enabled(dev, NULL);
 	if (IS_ERR(lpc_snoop->clk)) {
 		rc = PTR_ERR(lpc_snoop->clk);
 		if (rc != -EPROBE_DEFER)
 			dev_err(dev, "couldn't get clock\n");
 		return rc;
 	}
-	rc = clk_prepare_enable(lpc_snoop->clk);
-	if (rc) {
-		dev_err(dev, "couldn't enable clock\n");
-		return rc;
-	}
 
 	rc = aspeed_lpc_snoop_config_irq(lpc_snoop, pdev);
 	if (rc)
-		goto err;
+		return rc;
 
 	rc = aspeed_lpc_enable_snoop(lpc_snoop, dev, ASPEED_LPC_SNOOP_INDEX_0, port);
 	if (rc)
-		goto err;
+		return rc;
 
 	/* Configuration of 2nd snoop channel port is optional */
 	if (of_property_read_u32_index(dev->of_node, "snoop-ports",
@@ -356,16 +351,11 @@ static int aspeed_lpc_snoop_probe(struct platform_device *pdev)
 		rc = aspeed_lpc_enable_snoop(lpc_snoop, dev, ASPEED_LPC_SNOOP_INDEX_1, port);
 		if (rc) {
 			aspeed_lpc_disable_snoop(lpc_snoop, ASPEED_LPC_SNOOP_INDEX_0);
-			goto err;
+			return rc;
 		}
 	}
 
 	return 0;
-
-err:
-	clk_disable_unprepare(lpc_snoop->clk);
-
-	return rc;
 }
 
 static void aspeed_lpc_snoop_remove(struct platform_device *pdev)
@@ -375,8 +365,6 @@ static void aspeed_lpc_snoop_remove(struct platform_device *pdev)
 	/* Disable both snoop channels */
 	aspeed_lpc_disable_snoop(lpc_snoop, ASPEED_LPC_SNOOP_INDEX_0);
 	aspeed_lpc_disable_snoop(lpc_snoop, ASPEED_LPC_SNOOP_INDEX_1);
-
-	clk_disable_unprepare(lpc_snoop->clk);
 }
 
 static const struct aspeed_lpc_snoop_model_data ast2400_model_data = {

-- 
2.39.5


  parent reply	other threads:[~2025-06-16 13:14 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-16 13:13 [PATCH v2 00/10] soc: aspeed: lpc-snoop: Miscellaneous fixes Andrew Jeffery
2025-06-16 13:13 ` [PATCH v2 01/10] soc: aspeed: lpc-snoop: Cleanup resources in stack-order Andrew Jeffery
2025-06-16 13:13 ` [PATCH v2 02/10] soc: aspeed: lpc-snoop: Don't disable channels that aren't enabled Andrew Jeffery
2025-06-16 13:13 ` [PATCH v2 03/10] soc: aspeed: lpc-snoop: Ensure model_data is valid Andrew Jeffery
2025-06-16 13:13 ` [PATCH v2 04/10] soc: aspeed: lpc-snoop: Constrain parameters in channel paths Andrew Jeffery
2025-07-04 16:44   ` Jean Delvare
2025-07-08  2:06     ` Andrew Jeffery
2025-06-16 13:13 ` [PATCH v2 05/10] soc: aspeed: lpc-snoop: Rename 'channel' to 'index' " Andrew Jeffery
2025-06-16 13:13 ` [PATCH v2 06/10] soc: aspeed: lpc-snoop: Rearrange " Andrew Jeffery
2025-07-04 15:34   ` Jean Delvare
2025-07-08  2:06     ` Andrew Jeffery
2025-06-16 13:13 ` Andrew Jeffery [this message]
2025-07-04 14:42   ` [PATCH v2 07/10] soc: aspeed: lpc-snoop: Switch to devm_clk_get_enabled() Jean Delvare
2025-06-16 13:13 ` [PATCH v2 08/10] soc: aspeed: lpc-snoop: Use dev_err_probe() where possible Andrew Jeffery
2025-07-04 14:46   ` Jean Delvare
2025-06-16 13:13 ` [PATCH v2 09/10] soc: aspeed: lpc-snoop: Consolidate channel initialisation Andrew Jeffery
2025-07-04 15:13   ` Jean Delvare
2025-07-08  2:06     ` Andrew Jeffery
2025-06-16 13:13 ` [PATCH v2 10/10] soc: aspeed: lpc-snoop: Lift channel config to const structs Andrew Jeffery
2025-07-04 16:23   ` Jean Delvare
2025-07-08  2:07     ` Andrew Jeffery

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250616-aspeed-lpc-snoop-fixes-v2-7-3cdd59c934d3@codeconstruct.com.au \
    --to=andrew@codeconstruct.com.au \
    --cc=bsdhenrymartin@gmail.com \
    --cc=geissonator@yahoo.com \
    --cc=jdelvare@suse.de \
    --cc=joel@jms.id.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ninad@linux.ibm.com \
    --cc=patrick.rudolph@9elements.com \
    --cc=roblip@gmail.com \
    --cc=venture@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®