mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
	linux-xfs@vger.kernel.org, Masami Hiramatsu <mhiramat@kernel.org>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Carlos Maiolino <cem@kernel.org>,
	"Darrick J. Wong" <djwong@kernel.org>
Subject: Re: [PATCH 07/14] xfs: ifdef out unused xfs_attr events
Date: Mon, 16 Jun 2025 10:52:14 -0400	[thread overview]
Message-ID: <20250616105214.797509de@batman.local.home> (raw)
In-Reply-To: <20250616052810.GB1148@lst.de>

On Mon, 16 Jun 2025 07:28:10 +0200
Christoph Hellwig <hch@lst.de> wrote:

> On Thu, Jun 12, 2025 at 05:24:12PM -0400, Steven Rostedt wrote:
> > From: Steven Rostedt <rostedt@goodmis.org>
> > 
> > Trace events can take up to 5K in memory for text and meta data per event
> > regardless if they are used or not, so they should not be defined when not
> > used. The events xfs_attr_fillstate and xfs_attr_refillstate are only
> > called in code that is #ifdef out and exists only for future reference.
> > 
> > Ifdef out the events that go with that code and add a comment mentioning
> > the other code.  
> 
> Just drop them entirely, which is what the code using them should
> have done as well.  We can always triviall bring back code from
> git history.

OK. But I'll only send a patch to delete the trace events. I'll let
someone else remove the actual code.

-- Steve

  reply	other threads:[~2025-06-16 14:52 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-12 21:24 [PATCH 00/14] xfs: Remove unused trace events Steven Rostedt
2025-06-12 21:24 ` [PATCH 01/14] xfs: tracing; Remove unused event xfs_reflink_cow_found Steven Rostedt
2025-06-13 15:38   ` Steven Rostedt
2025-06-13 23:52   ` kernel test robot
2025-06-12 21:24 ` [PATCH 02/14] xfs: Remove unused trace event xfs_attr_remove_iter_return Steven Rostedt
2025-06-16  5:26   ` Christoph Hellwig
2025-06-16 14:51     ` Steven Rostedt
2025-06-12 21:24 ` [PATCH 03/14] xfs: Remove unused event xlog_iclog_want_sync Steven Rostedt
2025-06-12 21:24 ` [PATCH 04/14] xfs: Remove unused event xfs_ioctl_clone Steven Rostedt
2025-06-12 21:24 ` [PATCH 05/14] xfs: Remove unused xfs_reflink_compare_extents events Steven Rostedt
2025-06-12 21:24 ` [PATCH 06/14] xfs: Remove unused trace event xfs_attr_rmtval_set Steven Rostedt
2025-06-12 21:24 ` [PATCH 07/14] xfs: ifdef out unused xfs_attr events Steven Rostedt
2025-06-16  5:28   ` Christoph Hellwig
2025-06-16 14:52     ` Steven Rostedt [this message]
2025-06-17  4:46       ` Christoph Hellwig
2025-06-12 21:24 ` [PATCH 08/14] xfs: Remove unused event xfs_attr_node_removename Steven Rostedt
2025-06-12 21:24 ` [PATCH 09/14] xfs: Remove unused event xfs_alloc_near_error Steven Rostedt
2025-06-12 21:24 ` [PATCH 10/14] xfs: Remove unused event xfs_alloc_near_nominleft Steven Rostedt
2025-06-12 21:24 ` [PATCH 11/14] xfs: Remove unused event xfs_pagecache_inval Steven Rostedt
2025-06-12 21:24 ` [PATCH 12/14] xfs: Remove usused xfs_end_io_direct events Steven Rostedt
2025-06-12 21:24 ` [PATCH 13/14] xfs: Only create event xfs_file_compat_ioctl when CONFIG_COMPAT is configure Steven Rostedt
2025-06-12 21:24 ` [PATCH 14/14] xfs: Change xfs_xattr_class from a TRACE_EVENT() to DECLARE_EVENT_CLASS() Steven Rostedt
2025-06-13 15:08 ` [PATCH 00/14] xfs: Remove unused trace events Darrick J. Wong
2025-06-13 15:31   ` Steven Rostedt
2025-06-16  5:31     ` Christoph Hellwig
2025-06-16 14:58       ` Steven Rostedt
2025-07-23 22:35   ` Steven Rostedt
2025-06-16  5:30 ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250616105214.797509de@batman.local.home \
    --to=rostedt@goodmis.org \
    --cc=akpm@linux-foundation.org \
    --cc=cem@kernel.org \
    --cc=djwong@kernel.org \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®