From: Simon Horman <horms@kernel.org>
To: David Thompson <davthompson@nvidia.com>
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, asmaa@nvidia.com,
u.kleine-koenig@baylibre.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v1] mlxbf_gige: emit messages during open and probe failures
Date: Mon, 16 Jun 2025 14:57:10 +0100 [thread overview]
Message-ID: <20250616135710.GA6918@horms.kernel.org> (raw)
In-Reply-To: <20250613174228.1542237-1-davthompson@nvidia.com>
On Fri, Jun 13, 2025 at 05:42:28PM +0000, David Thompson wrote:
> The open() and probe() functions of the mlxbf_gige driver
> check for errors during initialization, but do not provide
> details regarding the errors. The mlxbf_gige driver should
> provide error details in the kernel log, noting what step
> of initialization failed.
>
> Signed-off-by: David Thompson <davthompson@nvidia.com>
Hi David,
I do have some reservations about the value of printing
out raw err values. But I also see that the logging added
by this patch is consistent with existing code in this driver.
So in that context I agree this is appropriate.
Reviewed-by: Simon Horman <horms@kernel.org>
...
next prev parent reply other threads:[~2025-06-16 13:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-13 17:42 David Thompson
2025-06-16 13:57 ` Simon Horman [this message]
2025-06-16 14:06 ` Alexander Lobakin
2025-06-16 19:17 ` Simon Horman
2025-07-01 0:44 ` David Thompson
2025-07-01 12:51 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250616135710.GA6918@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=asmaa@nvidia.com \
--cc=davem@davemloft.net \
--cc=davthompson@nvidia.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®