mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Danilo Krummrich <dakr@kernel.org>
To: igor.korotin.linux@gmail.com, gregkh@linuxfoundation.org,
	rafael@kernel.org, ojeda@kernel.org, alex.gaynor@gmail.com,
	boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com,
	benno.lossin@proton.me, a.hindborg@kernel.org,
	aliceryhl@google.com, tmgross@umich.edu
Cc: rust-for-linux@vger.kernel.org, linux-acpi@vger.kernel.org,
	linux-kernel@vger.kernel.org, Danilo Krummrich <dakr@kernel.org>
Subject: [PATCH 2/3] samples: rust: platform: don't call as_ref() repeatedly
Date: Mon, 16 Jun 2025 21:40:20 +0200	[thread overview]
Message-ID: <20250616194439.68775-2-dakr@kernel.org> (raw)
In-Reply-To: <20250616194439.68775-1-dakr@kernel.org>

In SampleDriver::probe() don't call pdev.as_ref() repeatedly, instead
introduce a dedicated &Device.

Signed-off-by: Danilo Krummrich <dakr@kernel.org>
---
 samples/rust/rust_driver_platform.rs | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/samples/rust/rust_driver_platform.rs b/samples/rust/rust_driver_platform.rs
index c0abf78d0683..000bb915af60 100644
--- a/samples/rust/rust_driver_platform.rs
+++ b/samples/rust/rust_driver_platform.rs
@@ -32,13 +32,15 @@ fn probe(
         pdev: &platform::Device<Core>,
         info: Option<&Self::IdInfo>,
     ) -> Result<Pin<KBox<Self>>> {
-        dev_dbg!(pdev.as_ref(), "Probe Rust Platform driver sample.\n");
+        let dev = pdev.as_ref();
+
+        dev_dbg!(dev, "Probe Rust Platform driver sample.\n");
 
         if let Some(info) = info {
-            dev_info!(pdev.as_ref(), "Probed with info: '{}'.\n", info.0);
+            dev_info!(dev, "Probed with info: '{}'.\n", info.0);
         }
 
-        Self::properties_parse(pdev.as_ref())?;
+        Self::properties_parse(dev)?;
 
         let drvdata = KBox::new(Self { pdev: pdev.into() }, GFP_KERNEL)?;
 
-- 
2.49.0


  reply	other threads:[~2025-06-16 19:44 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-13 13:35 [PATCH v6 0/6] rust: Add ACPI match table support for Rust drivers Igor Korotin
2025-06-13 13:38 ` [PATCH v6 1/6] rust: acpi: add `acpi::DeviceId` abstraction Igor Korotin
2025-06-16 20:03   ` Danilo Krummrich
2025-06-13 13:40 ` [PATCH v6 2/6] rust: driver: Consolidate `Adapter::of_id_info` methods using `#[cfg]` Igor Korotin
2025-06-13 13:43 ` [PATCH v6 3/6] rust: driver: Add ACPI id table support to Adapter trait Igor Korotin
2025-06-13 13:45 ` [PATCH v6 4/6] rust: platform: Set `OF_ID_TABLE` default to `None` in `Driver` trait Igor Korotin
2025-06-13 13:49 ` [PATCH v6 5/6] rust: platform: Add ACPI match table support to " Igor Korotin
2025-06-13 13:54 ` [PATCH v6 6/6] samples: rust: add ACPI match table example to platform driver Igor Korotin
2025-06-16 19:40   ` [PATCH 1/3] rust: device: implement FwNode::is_compatible() Danilo Krummrich
2025-06-16 19:40     ` Danilo Krummrich [this message]
2025-06-17  7:10       ` [PATCH 2/3] samples: rust: platform: don't call as_ref() repeatedly Dirk Behme
2025-06-16 19:40     ` [PATCH 3/3] samples: rust: platform: conditionally call Self::properties_parse() Danilo Krummrich
2025-06-16 19:52   ` [PATCH v6 6/6] samples: rust: add ACPI match table example to platform driver Danilo Krummrich
2025-06-17 16:39     ` Igor Korotin
2025-06-17 17:15       ` Danilo Krummrich
2025-06-25  9:17         ` Rafael J. Wysocki
2025-06-25  9:27           ` Danilo Krummrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250616194439.68775-2-dakr@kernel.org \
    --to=dakr@kernel.org \
    --cc=a.hindborg@kernel.org \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=benno.lossin@proton.me \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=gary@garyguo.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=igor.korotin.linux@gmail.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rafael@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tmgross@umich.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®