From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Peter Zijlstra <peterz@infradead.org>
Cc: "Luis Claudio R. Goncalves" <lgoncalv@redhat.com>,
Clark Williams <clrkwllms@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>, Tejun Heo <tj@kernel.org>,
David Vernet <dvernet@meta.com>, Barret Rhoden <brho@google.com>,
Josh Don <joshdon@google.com>, Crystal Wood <crwood@redhat.com>,
linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev,
Juri Lelli <juri.lelli@redhat.com>,
Ben Segall <bsegall@google.com>,
DietmarEggemann@uudg.org, dietmar.eggemann@arm.com,
Ingo Molnar <mingo@redhat.com>, Mel Gorman <mgorman@suse.de>,
Valentin Schneider <vschneid@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Wander Lairson Costa <wander@redhat.com>
Subject: Re: [RESEND PATCH v4] sched: do not call __put_task_struct() on rt if pi_blocked_on is set
Date: Tue, 17 Jun 2025 11:36:27 +0200 [thread overview]
Message-ID: <20250617093627.ykSeZMqk@linutronix.de> (raw)
In-Reply-To: <20250617092609.GR1613376@noisy.programming.kicks-ass.net>
On 2025-06-17 11:26:09 [+0200], Peter Zijlstra wrote:
> On Fri, Jun 13, 2025 at 12:05:14PM -0300, Luis Claudio R. Goncalves wrote:
> > With PREEMPT_RT enabled, some of the calls to put_task_struct() coming
> > from rt_mutex_adjust_prio_chain() could happen in preemptible context and
> > with a mutex enqueued. That could lead to this sequence:
> >
> > rt_mutex_adjust_prio_chain()
> > put_task_struct()
> > __put_task_struct()
> > sched_ext_free()
> > spin_lock_irqsave()
> > rtlock_lock() ---> TRIGGERS
> > lockdep_assert(!current->pi_blocked_on);
> >
> > Fix that by unconditionally resorting to the deferred call to
> > __put_task_struct() if PREEMPT_RT is enabled.
> >
>
> Should this have a Fixes: tag and go into /urgent?
I would say so. I'm not sure what caused it. I think Luis said at some
point that it is caused by a sched_ext case or I mixed it up with
something. Luis?
The other question I have, do we need to distinguish between PREEMPT_RT
and not or can we do this unconditionally?
Sebastian
next prev parent reply other threads:[~2025-06-17 9:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-13 15:05 Luis Claudio R. Goncalves
2025-06-16 11:03 ` Wander Lairson Costa
2025-06-17 9:26 ` Peter Zijlstra
2025-06-17 9:36 ` Sebastian Andrzej Siewior [this message]
2025-06-17 10:52 ` Wander Lairson Costa
2025-06-17 13:10 ` Luis Claudio R. Goncalves
2025-06-17 13:16 ` Luis Claudio R. Goncalves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250617093627.ykSeZMqk@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=DietmarEggemann@uudg.org \
--cc=brho@google.com \
--cc=bsegall@google.com \
--cc=clrkwllms@kernel.org \
--cc=crwood@redhat.com \
--cc=dietmar.eggemann@arm.com \
--cc=dvernet@meta.com \
--cc=joshdon@google.com \
--cc=juri.lelli@redhat.com \
--cc=lgoncalv@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-devel@lists.linux.dev \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=wander@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®