From: Steven Rostedt <rostedt@goodmis.org>
To: Artem Sadovnikov <a.sadovnikov@ispras.ru>
Cc: linux-kernel@vger.kernel.org,
Masami Hiramatsu <mhiramat@kernel.org>,
lvc-project@linuxtesting.org
Subject: Re: [PATCH] function_graph: Fix off-by-one error in buffer size
Date: Tue, 17 Jun 2025 11:02:45 -0400 [thread overview]
Message-ID: <20250617110245.5b68ab97@gandalf.local.home> (raw)
In-Reply-To: <20250617110017.2883cba3@gandalf.local.home>
On Tue, 17 Jun 2025 11:00:17 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> On Tue, 17 Jun 2025 11:19:06 +0000
> Artem Sadovnikov <a.sadovnikov@ispras.ru> wrote:
>
> > The comment above buffer mentions sign, 10 bytes width for number and null
> > terminator, but buffer itself isn't large enough to hold that much data.
> >
> > This is a cosmetic change, since PID cannot be negative, other than -1.
>
> Right, where I'll change the subject as that makes it look like this is a
> real bug.
Can your resend and Cc linux-trace-kernel@vger.kernel.org otherwise it will
not get into the patchwork queue.
Rename the Subject to:
fgraph: Make pid_str size match the comment
Thanks!
-- Steve
prev parent reply other threads:[~2025-06-17 15:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-17 11:19 Artem Sadovnikov
2025-06-17 15:00 ` Steven Rostedt
2025-06-17 15:02 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250617110245.5b68ab97@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=a.sadovnikov@ispras.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=mhiramat@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®