From: Borislav Petkov <bp@alien8.de>
To: Avadhut Naik <avadhut.naik@amd.com>
Cc: linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
yazen.ghannam@amd.com, mario.limonciello@amd.com,
reox <mailinglist@reox.at>
Subject: Re: [PATCH] EDAC/amd64: Correct number of UMCs for Family 19h Models 70h-7fh
Date: Tue, 17 Jun 2025 13:41:54 +0200 [thread overview]
Message-ID: <20250617114154.GAaFFUgo6SVroOaP02@fat_crate.local> (raw)
In-Reply-To: <20250613005233.2330627-1-avadhut.naik@amd.com>
On Fri, Jun 13, 2025 at 12:51:35AM +0000, Avadhut Naik wrote:
> AMD's Family 19h-based Models 70h-7fh support 4 UMCs per processor die.
>
> The amd64_edac module, however, assumes only 2 UMCs are supported since
> max_mcs variable for the models has not been explicitly set to 4. The
> same results in incomplete or incorrect memory information being logged
> to dmesg by the module during initialization in some instances.
>
> Fixes: 6c79e42169fe ("EDAC/amd64: Add support for ECC on family 19h model 60h-7Fh")
> Reported-by: reox <mailinglist@reox.at>
> Closes: https://lore.kernel.org/all/27dc093f-ce27-4c71-9e81-786150a040b6@reox.at/
> Signed-off-by: Avadhut Naik <avadhut.naik@amd.com>
> Cc: stable@kernel.org
> ---
> drivers/edac/amd64_edac.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c
> index 90f0eb7cc5b9..390f5756b66e 100644
> --- a/drivers/edac/amd64_edac.c
> +++ b/drivers/edac/amd64_edac.c
> @@ -3879,6 +3879,7 @@ static int per_family_init(struct amd64_pvt *pvt)
> break;
> case 0x70 ... 0x7f:
> pvt->ctl_name = "F19h_M70h";
> + pvt->max_mcs = 4;
> pvt->flags.zn_regs_v2 = 1;
> break;
> case 0x90 ... 0x9f:
>
> base-commit: 855b5de2e562c07d6cda4deb08d09dc2e0e2b18d
> --
Applied, thanks.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
prev parent reply other threads:[~2025-06-17 11:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-13 0:51 Avadhut Naik
2025-06-17 11:41 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250617114154.GAaFFUgo6SVroOaP02@fat_crate.local \
--to=bp@alien8.de \
--cc=avadhut.naik@amd.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailinglist@reox.at \
--cc=mario.limonciello@amd.com \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®