From: Nam Tran <trannamatk@gmail.com>
To: krzk+dt@kernel.org
Cc: lee@kernel.org, pavel@kernel.org, robh@kernel.org,
conor+dt@kernel.org, corbet@lwn.net, linux-leds@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-doc@vger.kernel.org
Subject: Re: [PATCH v9 0/4] leds: add new LED driver for TI LP5812
Date: Tue, 17 Jun 2025 22:40:20 +0700 [thread overview]
Message-ID: <20250617154020.7785-1-trannamatk@gmail.com> (raw)
In-Reply-To: <e26093a7-2305-4d55-b836-d3bc7c503b9b@kernel.org>
On Wed, 11 Jun 2025, Krzysztof Kozlowski wrote:
> On 10/06/2025 19:43, Nam Tran wrote:
> > This patch series adds support for the TI/National Semiconductor LP5812
> > 4x3 matrix RGB LED driver. The driver supports features such as autonomous
> > animation and time-cross-multiplexing (TCM) for dynamic LED effects.
> >
> > Following feedback from both the LED and auxdisplay subsystem maintainers,
> > the driver has been moved back to the LED subsystem, under drivers/leds/rgb/.
> > This version integrates with the existing multicolor LED APIs, avoiding custom
> > sysfs where standard LED interfaces are sufficient.
> >
> > Signed-off-by: Nam Tran <trannamatk@gmail.com>
> > ---
> > Changes in v9:
> > - Move driver back to drivers/leds/rgb/
> > - Integrate with LED multicolor framework
> > - Refactor and simplify custom sysfs handling
> > - Extend Device Tree binding to support multi-led@ nodes using leds-class-multicolor.yaml
>
> You need to provide reason why you dropped reviews.
In v9, the Device Tree binding was restructured to integrate with the standard
leds-class-multicolor.yaml schema and support multi-led@ nodes with nested led@
subnodes. This change introduced a new patternProperties hierarchy and removed
the previous flat led@ layout used in the earlier versions.
Due to this substantial structural change — even though the intent and top-level
properties remained similar — I decided to drop the Reviewed-by tag to avoid
misrepresenting prior review coverage.
I will include this explanation in the changelog of the next version (v10).
Best regards,
Nam Tran
prev parent reply other threads:[~2025-06-17 15:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-10 17:43 Nam Tran
2025-06-10 17:43 ` [PATCH v9 1/4] dt-bindings: leds: add TI/National Semiconductor LP5812 LED Driver Nam Tran
2025-06-11 8:24 ` Krzysztof Kozlowski
2025-06-17 16:29 ` Nam Tran
2025-06-10 17:43 ` [PATCH v5] test Nam Tran
2025-06-12 10:03 ` Lee Jones
2025-06-17 17:46 ` Nam Tran
2025-06-10 17:43 ` [PATCH v9 2/4] leds: add TI/National Semiconductor LP5812 LED Driver Nam Tran
2025-06-10 18:13 ` Randy Dunlap
2025-06-17 16:50 ` Nam Tran
2025-06-10 21:07 ` Christophe JAILLET
2025-06-17 17:30 ` Nam Tran
2025-06-16 18:37 ` kernel test robot
2025-06-10 17:43 ` [PATCH v9 3/4] docs: ABI: Document LP5812 LED sysfs interfaces Nam Tran
2025-06-10 17:43 ` [PATCH v9 4/4] docs: leds: Document TI LP5812 LED driver Nam Tran
2025-06-10 17:55 ` [PATCH v9 0/4] leds: add new LED driver for TI LP5812 Nam Tran
2025-06-11 6:59 ` Krzysztof Kozlowski
2025-06-17 15:40 ` Nam Tran [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250617154020.7785-1-trannamatk@gmail.com \
--to=trannamatk@gmail.com \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®