mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joel Fernandes <joelagnelf@nvidia.com>
To: linux-kernel@vger.kernel.org, Tejun Heo <tj@kernel.org>,
	David Vernet <void@manifault.com>,
	Andrea Righi <arighi@nvidia.com>,
	Changwoo Min <changwoo@igalia.com>,
	Ingo Molnar <mingo@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Juri Lelli <juri.lelli@redhat.com>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
	Valentin Schneider <vschneid@redhat.com>
Cc: Joel Fernandes <joelagnelf@nvidia.com>
Subject: [PATCH v4 12/15] sched_ext: Update rq clock when stopping dl_server
Date: Tue, 17 Jun 2025 16:05:15 -0400	[thread overview]
Message-ID: <20250617200523.1261231-13-joelagnelf@nvidia.com> (raw)
In-Reply-To: <20250617200523.1261231-1-joelagnelf@nvidia.com>

From: Andrea Righi <arighi@nvidia.com>

Call update_rq_clock() before invoking dl_server_stop() to ensure proper
time tracking and behavior.

Signed-off-by: Andrea Righi <arighi@nvidia.com>
---
 kernel/sched/ext.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/kernel/sched/ext.c b/kernel/sched/ext.c
index 562cd28ff42f..84ccab8cb838 100644
--- a/kernel/sched/ext.c
+++ b/kernel/sched/ext.c
@@ -5000,9 +5000,9 @@ static void scx_disable_workfn(struct kthread_work *work)
 		 * server bandwidth will be re-initialized.
 		 */
 		rq_lock_irqsave(rq, &rf);
-		if (dl_server_active(&rq->ext_server)) {
+		update_rq_clock(rq);
+		if (dl_server_active(&rq->ext_server))
 			dl_server_stop(&rq->ext_server);
-		}
 		dl_server_remove_params(&rq->ext_server);
 		rq_unlock_irqrestore(rq, &rf);
 	}
@@ -5754,6 +5754,7 @@ static int scx_enable(struct sched_ext_ops *ops, struct bpf_link *link)
 			 * re-initialized.
 			 */
 			rq_lock_irqsave(rq, &rf);
+			update_rq_clock(rq);
 			if (dl_server_active(&rq->fair_server))
 				dl_server_stop(&rq->fair_server);
 			dl_server_remove_params(&rq->fair_server);
-- 
2.43.0


  parent reply	other threads:[~2025-06-17 20:06 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-17 20:05 [PATCH v4 00/15] Add a deadline server for sched_ext tasks Joel Fernandes
2025-06-17 20:05 ` [PATCH v4 01/15] sched/debug: Fix updating of ppos on server write ops Joel Fernandes
2025-06-17 20:05 ` [PATCH v4 02/15] sched/debug: Stop and start server based on if it was active Joel Fernandes
2025-06-17 20:05 ` [PATCH v4 03/15] sched/deadline: Clear the defer params Joel Fernandes
2025-06-17 20:05 ` [PATCH v4 04/15] sched/deadline: Prevent setting server as started if params couldn't be applied Joel Fernandes
2025-06-17 20:05 ` [PATCH v4 05/15] sched/deadline: Return EBUSY if dl_bw_cpus is zero Joel Fernandes
2025-06-17 20:05 ` [PATCH v4 06/15] sched: Add support to pick functions to take rf Joel Fernandes
2025-06-17 20:05 ` [PATCH v4 07/15] sched: Add a server arg to dl_server_update_idle_time() Joel Fernandes
2025-06-17 20:05 ` [PATCH v4 08/15] sched/ext: Add a DL server for sched_ext tasks Joel Fernandes
2025-06-17 20:05 ` [PATCH v4 09/15] sched/debug: Add support to change sched_ext server params Joel Fernandes
2025-06-17 20:05 ` [PATCH v4 10/15] sched/deadline: Add support to remove DLserver's bandwidth contribution Joel Fernandes
2025-06-17 20:05 ` [PATCH v4 11/15] sched/ext: Relinquish DL server reservations when not needed Joel Fernandes
2025-06-17 20:05 ` Joel Fernandes [this message]
2025-06-17 20:05 ` [PATCH v4 13/15] selftests/sched_ext: Add test for sched_ext dl_server Joel Fernandes
2025-06-17 20:05 ` [PATCH v4 14/15] Remove the ext server BW before changing tasks to FAIR Joel Fernandes
2025-06-17 20:12   ` Joel Fernandes
2025-06-17 20:42   ` Andrea Righi
2025-06-18 13:21     ` Joel Fernandes
2025-06-17 20:05 ` [PATCH v4 15/15] sched/deadline: Fix DL server crash in inactive_timer callback Joel Fernandes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250617200523.1261231-13-joelagnelf@nvidia.com \
    --to=joelagnelf@nvidia.com \
    --cc=arighi@nvidia.com \
    --cc=bsegall@google.com \
    --cc=changwoo@igalia.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tj@kernel.org \
    --cc=vincent.guittot@linaro.org \
    --cc=void@manifault.com \
    --cc=vschneid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®