mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Dharma.B@microchip.com
Cc: asrivats@redhat.com, dri-devel@lists.freedesktop.org,
	Manikandan.M@microchip.com, neil.armstrong@linaro.org,
	rfoss@kernel.org, jonas@kwiboo.se, jernej.skrabec@gmail.com,
	maarten.lankhorst@linux.intel.com, mripard@kernel.org,
	tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch,
	linux-kernel@vger.kernel.org
Subject: Re: bridge/microchip_lvds panel usage
Date: Wed, 18 Jun 2025 11:55:45 +0300	[thread overview]
Message-ID: <20250618085545.GC28826@pendragon.ideasonboard.com> (raw)
In-Reply-To: <f10ee1ce-5362-4dc9-8e61-726db9c27d64@microchip.com>

On Wed, Jun 18, 2025 at 03:50:11AM +0000, Dharma.B@microchip.com wrote:
> On 18/06/25 5:06 am, Laurent Pinchart wrote:
> > On Tue, Jun 17, 2025 at 10:36:34AM -0500, Anusha Srivatsa wrote:
> >> Hey folks,
> >>
> >> Can someone please explain why the driver looks for a panel here:
> >> https://elixir.bootlin.com/linux/v6.14.11/source/drivers/gpu/drm/bridge/
> >> microchip-lvds.c#L182 and doesnt use it or set it up anywhere?
> >>
> >> I bumped into this while working on converting of_drm_find_panel() callers and
> >> the lvds->panel usage in this driver felt off. Am I missing something?
> > 
> > That doesn't seem needed.
> 
> Currently the LVDS controller driver is hardcoded to map LVDS lanes to 
> the JEIDA format.
> 
> In order to support the other format "VESA", we need this to query the 
> panel driver and set the appropriate format accordingly.
> 
> "drm_panel_get_modes(lvds->panel, connector)"

It would be nice if this could be done using the bridge API instead. An
LVDS sink does not necessarily need to be a panel.

> We'll be submitting the patch upstream shortly.
> 
> > By the way, please use plain text when posting to kernel mailing lists.

-- 
Regards,

Laurent Pinchart

  reply	other threads:[~2025-06-18  8:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAN9Xe3RV9aZLJ3zV3zip5MQweGbBghdOFGohd6Qg-XjvFoGing@mail.gmail.com>
2025-06-17 23:36 ` Laurent Pinchart
2025-06-18  3:50   ` Dharma.B
2025-06-18  8:55     ` Laurent Pinchart [this message]
2025-06-23 10:54       ` Dharma.B

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250618085545.GC28826@pendragon.ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=Dharma.B@microchip.com \
    --cc=Manikandan.M@microchip.com \
    --cc=airlied@gmail.com \
    --cc=asrivats@redhat.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=jonas@kwiboo.se \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=rfoss@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®