From: Petr Pavlu <petr.pavlu@suse.com>
To: Luis Chamberlain <mcgrof@kernel.org>,
Petr Pavlu <petr.pavlu@suse.com>,
Sami Tolvanen <samitolvanen@google.com>,
Daniel Gomez <da.gomez@samsung.com>
Cc: linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 2/2] module: Avoid unnecessary return value initialization in move_module()
Date: Wed, 18 Jun 2025 14:26:27 +0200 [thread overview]
Message-ID: <20250618122730.51324-3-petr.pavlu@suse.com> (raw)
In-Reply-To: <20250618122730.51324-1-petr.pavlu@suse.com>
All error conditions in move_module() set the return value by updating the
ret variable. Therefore, it is not necessary to the initialize the variable
when declaring it.
Remove the unnecessary initialization.
Signed-off-by: Petr Pavlu <petr.pavlu@suse.com>
Reviewed-by: Sami Tolvanen <samitolvanen@google.com>
---
kernel/module/main.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/kernel/module/main.c b/kernel/module/main.c
index 9ac994b2f354..7822b91fca6b 100644
--- a/kernel/module/main.c
+++ b/kernel/module/main.c
@@ -2696,9 +2696,8 @@ static int find_module_sections(struct module *mod, struct load_info *info)
static int move_module(struct module *mod, struct load_info *info)
{
- int i;
+ int i, ret;
enum mod_mem_type t = MOD_MEM_NUM_TYPES;
- int ret = -ENOMEM;
bool codetag_section_found = false;
for_each_mod_mem_type(type) {
--
2.49.0
next prev parent reply other threads:[~2025-06-18 12:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-18 12:26 [PATCH v2 0/2] module: Fix memory deallocation on error path " Petr Pavlu
2025-06-18 12:26 ` [PATCH v2 1/2] " Petr Pavlu
2025-06-18 14:02 ` Daniel Gomez
2025-06-30 12:09 ` Daniel Gomez
2025-06-18 12:26 ` Petr Pavlu [this message]
2025-06-18 14:02 ` [PATCH v2 2/2] module: Avoid unnecessary return value initialization " Daniel Gomez
2025-06-30 13:57 ` [PATCH v2 0/2] module: Fix memory deallocation on error path " Daniel Gomez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250618122730.51324-3-petr.pavlu@suse.com \
--to=petr.pavlu@suse.com \
--cc=da.gomez@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=samitolvanen@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®