mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chiang Brian <chiang.brian@inventec.com>
To: jdelvare@suse.com, linux@roeck-us.net, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org
Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Chiang Brian <chiang.brian@inventec.com>
Subject: [PATCH v10 0/2] Add tps53685 support
Date: Thu, 19 Jun 2025 14:42:21 +0800	[thread overview]
Message-ID: <20250619064223.3165523-1-chiang.brian@inventec.com> (raw)

The TPS53685 is a fully AMD SVI3 compliant step down controller with
trans-inductor voltage regulator(TLVR) topology support, dual channels,
built-in non-volatile memory (NVM), PMBus interface, and full compatible
with TI NexFET smart power stages.

Add support for TPS53685 device to dt-bindings and pmbus driver.

---
v9 -> v10:
- Fix the inconsistent indenting in switch case with tab instead of space
- Run the smatch kchecker to confirm
- Link to v9: https://lore.kernel.org/all/20250610102556.236300-1-chiang.brian@inventec.com/

v8 -> v9:
- dt-bindings: Correct the order of Acked-by tag
- hwmon: Fix the alignment to match open parenthesis
- Wrap commit message body at 75 columns
- Link to v8: https://lore.kernel.org/all/20250602042454.184643-2-chiang.brian@inventec.com/

v7 -> v8:
- dt-bindings: Include missing Acked-by tag
- dt-bindings: Patch kept in sync with series version
- hwmon: Fixed device_id parameter type and test make.cross of i386
- Link to dt-bindings v3: https://lore.kernel.org/all/20250515081449.1433772-2-chiang.brian@inventec.com/
- Link to hwmon v7: https://lore.kernel.org/all/20250515081449.1433772-3-chiang.brian@inventec.com/

v6 -> v7:
- dt-bindings: Fix the order of patches
- hwmon: Modify the type of device_id from u16 to char *
- Run make.cross with ARCH nios2, powerpc, and riscv
- Link to dt-bindings v2: https://lore.kernel.org/all/20250424132538.2004510-3-chiang.brian@inventec.corp-partner.google.com/
- Link to hwmon v6: https://lore.kernel.org/all/20250424132538.2004510-2-chiang.brian@inventec.corp-partner.google.com/

v5 -> v6:
- dt-bindings: Correct the subject and commit message
- hwmon: information about tps53685 into tps53679.rst
- hwmon: Add additional flags when identifing the chip as tps53685
- hwmon: Adjust length once returned device id is terminated by null character
- Link to dt-bindings v1: https://lore.kernel.org/all/20250314032802.3187097-1-chiang.brian@inventec.com/
- Link to hwmon v5: https://lore.kernel.org/all/20250314033040.3190642-1-chiang.brian@inventec.com/

v4 -> v5: 
- add support for tps53685 in dt-bindings
- add the buffer length as argument for %*ph
- Add Changelog
- Link to v4: https://lore.kernel.org/all/CAJCfHmW61d2jd_tYpNEqBG_Z58bEnVKAmsvhrEP1zXQoXqrUVw@mail.gmail.com/

v3 -> v4: 
- Add length comparison into the comparison of "id",or it may be true when
  the substring of "id" matches device id. 
- Restore `return 0;` in `tps53679_identify_chip()`
- Link to v3: https://lore.kernel.org/all/CAJCfHmVyaDPh0_ThPjhBP0zMO1oE1AR=4=Zsa0cMPXU3J4v6dw@mail.gmail.com/

v2 -> v3:
- Remove the length comparsion in the comparison of "id".
- Link to v2: https://lore.kernel.org/all/CAJCfHmUteFM+nUZWBWvmwFjALg1QUL5r+=syU1HmYTL1ewQWqA@mail.gmail.com/

v1 -> v2: 
- Modify subject and description to meet requirements
- Add "tps53685" into enum chips with numeric order
- Modify the content of marco "TPS53681_DEVICE_ID" from 0x81 to "\x81" 
- Add marco "TPS53685_DEVICE_ID" with content "TIShP"
- Modify the type of "id" from u16 to char* in `tps53679_identify_chip()`
- Modify the comparison of "id". It will be true if the string "id" matches
  device ID and compare with type char*
- Add the length comparsion into the comparison of "id".
- Modify "len" as return code in `tps53679_identify_chip()`
- Output device error log with %*ph, instead of 0x%x\n" 
- Use existing tps53679_identify_multiphase() with argument 
  "TPS53685_DEVICE_ID" in tps53685_identify() rather than creating one 
  tps53685_identify_multiphase()
- Link to v1: https://lore.kernel.org/all/CAJCfHmVy3O4-nz2_PKF7TcXYr+HqTte1-bdUWLBmV7JOS7He1g@mail.gmail.com/

Chiang Brian (2):
  dt-bindings: trivial: Add tps53685 support
  hwmon: (pmbus/tps53679) Add support for TPS53685

 .../devicetree/bindings/trivial-devices.yaml  |  2 +
 Documentation/hwmon/tps53679.rst              |  8 ++++
 drivers/hwmon/pmbus/tps53679.c                | 37 ++++++++++++++++---
 3 files changed, 41 insertions(+), 6 deletions(-)

-- 
2.43.0


             reply	other threads:[~2025-06-19  6:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-19  6:42 Chiang Brian [this message]
2025-06-19  6:42 ` [PATCH v10 1/2] dt-bindings: trivial: " Chiang Brian
2025-07-16 20:09   ` Guenter Roeck
2025-06-19  6:42 ` [PATCH v10 2/2] hwmon: (pmbus/tps53679) Add support for TPS53685 Chiang Brian
2025-07-16 20:09   ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250619064223.3165523-1-chiang.brian@inventec.com \
    --to=chiang.brian@inventec.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jdelvare@suse.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®