From: Lee Jones <lee@kernel.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Matti Vaittinen <mazziesaccount@gmail.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] mfd: rohm-bd71828: Constify some structures
Date: Thu, 19 Jun 2025 13:00:33 +0100 [thread overview]
Message-ID: <20250619120033.GM587864@google.com> (raw)
In-Reply-To: <d56bac346e94ac91df16a775c59092d1b60efabd.1750005148.git.christophe.jaillet@wanadoo.fr>
On Sun, 15 Jun 2025, Christophe JAILLET wrote:
> Several structures are not modified in this driver. Constifying them moves
> some data to a read-only section, so increases overall security, especially
> when the structure holds some function pointers. This is the case for
> 'gpio_keys_platform_data' and 'mfd_cell'.
>
> On a x86_64, with allmodconfig:
> Before:
> ======
> text data bss dec hex filename
> 18161 14112 192 32465 7ed1 drivers/mfd/rohm-bd71828.o
>
> After:
> =====
> text data bss dec hex filename
> 22897 9376 192 32465 7ed1 drivers/mfd/rohm-bd71828.o
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> Compile tested only
> ---
> drivers/mfd/rohm-bd71828.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
Doesn't apply. Please rebase and resubmit.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2025-06-19 12:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-15 16:32 Christophe JAILLET
2025-06-16 5:59 ` Matti Vaittinen
2025-06-19 12:00 ` Lee Jones [this message]
2025-06-25 10:12 ` (subset) " Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250619120033.GM587864@google.com \
--to=lee@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®