From: Lee Jones <lee@kernel.org>
To: Alex Elder <elder@riscstar.com>
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
broonie@kernel.org, lgirdwood@gmail.com, wangruikang@iscas.ac.cn,
dlan@gentoo.org, troymitchell988@gmail.com,
paul.walmsley@sifive.com, palmer@dabbelt.com,
aou@eecs.berkeley.edu, alex@ghiti.fr, devicetree@vger.kernel.org,
spacemit@lists.linux.dev, linux-riscv@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/6] mfd: spacemit: add support for SpacemiT PMICs
Date: Thu, 19 Jun 2025 15:44:42 +0100 [thread overview]
Message-ID: <20250619144442.GI795775@google.com> (raw)
In-Reply-To: <20250619135151.3206258-3-elder@riscstar.com>
On Thu, 19 Jun 2025, Alex Elder wrote:
> Add support for SpacemiT PMICs. Initially only the P1 PMIC is supported
> but the driver is structured to allow support for others to be added.
>
> The P1 PMIC is controlled by I2C, and is normally implemented with the
> SpacemiT K1 SoC. This PMIC provides six buck converters and 12 LDO
> regulators. It also implements a switch, watchdog timer, real-time clock,
> and more, but initially we will only support its regulators.
>
> Signed-off-by: Alex Elder <elder@riscstar.com>
> ---
> v2: - Use module_i2c_driver()
> - Expanded Kconfig module help text
> - Add MODULE_ALIAS(), and define and use DRV_NAME
>
> drivers/mfd/Kconfig | 13 ++++++
> drivers/mfd/Makefile | 1 +
> drivers/mfd/spacemit-pmic.c | 83 +++++++++++++++++++++++++++++++++++++
> 3 files changed, 97 insertions(+)
> create mode 100644 drivers/mfd/spacemit-pmic.c
All comments fro v1 are still relevant.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2025-06-19 14:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-19 13:51 [PATCH v2 0/6] spacemit: introduce P1 PMIC and regulator support Alex Elder
2025-06-19 13:51 ` [PATCH v2 1/6] dt-bindings: mfd: add support the SpacemiT P1 PMIC Alex Elder
2025-06-19 13:51 ` [PATCH v2 2/6] mfd: spacemit: add support for SpacemiT PMICs Alex Elder
2025-06-19 14:44 ` Lee Jones [this message]
2025-06-19 13:51 ` [PATCH v2 3/6] regulator: spacemit: support SpacemiT P1 regulators Alex Elder
2025-06-19 13:51 ` [PATCH v2 4/6] riscv: dts: spacemit: enable the i2c8 adapter Alex Elder
2025-06-19 13:51 ` [PATCH v2 5/6] riscv: dts: spacemit: define fixed regulators Alex Elder
2025-06-19 13:51 ` [PATCH v2 6/6] riscv: dts: spacemit: define regulator constraints Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250619144442.GI795775@google.com \
--to=lee@kernel.org \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlan@gentoo.org \
--cc=elder@riscstar.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
--cc=spacemit@lists.linux.dev \
--cc=troymitchell988@gmail.com \
--cc=wangruikang@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®