From: Abhinav Ananthu <abhinav.ogl@gmail.com>
To: andersson@kernel.org, mathieu.poirier@linaro.org
Cc: linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
Abhinav Ananthu <abhinav.ogl@gmail.com>,
Abhinav Ananthu <your_email@example.com>
Subject: [PATCH] remoteproc: debugfs: Replace scnprintf() with sysfs_emit()
Date: Fri, 20 Jun 2025 00:10:52 +0530 [thread overview]
Message-ID: <20250619184051.95066-1-abhinav.ogl@gmail.com> (raw)
Convert the debugfs show() functions in remoteproc_debugfs.c to use
sysfs_emit() instead of scnprintf(). The sysfs_emit() helper is the
preferred way to format sysfs output as it ensures the output is
properly bounded to PAGE_SIZE and simplifies the code.
This patch addresses three instances of scnprintf() usage in the file.
Signed-off-by: Abhinav Ananthu <your_email@example.com>
---
drivers/remoteproc/remoteproc_debugfs.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/remoteproc/remoteproc_debugfs.c b/drivers/remoteproc/remoteproc_debugfs.c
index b86c1d09c70c..691fd523e0b5 100644
--- a/drivers/remoteproc/remoteproc_debugfs.c
+++ b/drivers/remoteproc/remoteproc_debugfs.c
@@ -46,8 +46,9 @@ static ssize_t rproc_coredump_read(struct file *filp, char __user *userbuf,
char buf[20];
int len;
- len = scnprintf(buf, sizeof(buf), "%s\n",
- rproc_coredump_str[rproc->dump_conf]);
+ len = sysfs_emit(buf, "%s\n",
+ rproc_coredump_str[rproc->dump_conf]);
+
return simple_read_from_buffer(userbuf, count, ppos, buf, len);
}
@@ -135,7 +136,7 @@ static ssize_t rproc_trace_read(struct file *filp, char __user *userbuf,
va = rproc_da_to_va(data->rproc, trace->da, trace->len, NULL);
if (!va) {
- len = scnprintf(buf, sizeof(buf), "Trace %s not available\n",
+ len = sysfs_emit(buf, "Trace %s not available\n",
trace->name);
va = buf;
} else {
@@ -160,7 +161,7 @@ static ssize_t rproc_name_read(struct file *filp, char __user *userbuf,
char buf[100];
int i;
- i = scnprintf(buf, sizeof(buf), "%.98s\n", rproc->name);
+ i = sysfs_emit(buf, "%.98s\n", rproc->name);
return simple_read_from_buffer(userbuf, count, ppos, buf, i);
}
--
2.34.1
next reply other threads:[~2025-06-19 18:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-19 18:40 Abhinav Ananthu [this message]
2025-06-19 19:04 Abhinav Ananthu
2025-06-19 19:19 ` Christophe JAILLET
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250619184051.95066-1-abhinav.ogl@gmail.com \
--to=abhinav.ogl@gmail.com \
--cc=andersson@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=your_email@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®